System Information
OSX 10.10.2, GTX980
Blender Version
Broken: 000dfc0
Worked: 2.74
Short description of error
Render Slots don't work when using compositor. When you try to toggle between slot 1 and slot 2 with "J", the first render in slot 1 disappears. So you cannot compare renders. Also, it makes some russian dude go "tsk tsk tsk" ;)
Exact steps for others to reproduce the error
Open attached file, render, hit J, render again, hit J --> first slot empty.
| rB Blender | |||
| rBecb3362a244f Fix T44396 - Compositing render slots don't work | |||
this is a know problem I believe its in our to do on the wiki cant find it at the moment. same problem with masks and the is a task open for that https://developer.blender.org/T44181
This is a regression after multiview merge while the other issue has existed before.
@Aaron Carlisle (Blendify), please when making comments on bug reports, avoid using first plurar person ("our to do"). People might mistake you for a developer and take the comments as a fact. Again, the help is welcome, but when you give feedback on issues you can't comment as a programmer, use language that makes it easier for people to discern that this is not an expert opinion or things can get confusing in the process.
Investigated here a bit, issue is is image_get_render_result where RenderResult can return a NULL rectf when we display from a renderslot (instead of render result). We can use calls like RE_RenderViewGetRectf to get a correct rectf in addition to RenderResult.rectf. This solves toggling between images but has issues when doing edits in the compositor (edited result gets lost). Leaving to Dalai for proper investigation.
@Antonis Ryakiotakis (psy-fi) the bug you reported on irc with my proposed fix (aka if you edit a renderslot which is not the latest one the compo buffer is lost) is not the regression that multiview introduced. (in fact I believe is the bug @Aaron Carlisle (Blendify) was referring to).
So I'll go ahead and commit my fix. More details in the commit log.