Page MenuHome
Create Task
Maniphest T44921

Cycles node editor, nodes position not maintained after Material panel changes
Closed, ResolvedPublic
Actions

Description

System Information
Linux Mint 17.1 Cinnamon x64
Windows 7 x64
Intel HD 3000
NVIDIA GTX 580m

Blender Version
Broken: Official 2.74 (Hash 000dfc0)
Worked: None that I know of

Short description of error
Node Editor - Material panel:
While nodes are changed in the Material panel, their previous node editor position is ignored, nodes jump to a new position next to a connected mix node; furthermore, while replacing more than one node connected to a mix node, both nodes jump to exactly the same position (on top of each other).

Exact steps for others to reproduce the error
Open the attached blend (simple instructions are provided (only 2 steps to follow))

Node position change example.blend86 KBDownload

For those not wanting to use the blend, please see example screen captures below


.

While discussing Cycles node editor:
Wondered about this for a while. Adding a new Cycles material, nodes always appear off-centre in node editor space (upper right, instead of centralised), is there a design reason for this?

One area where this can be problematic; If the viewport is split and contains a small node editor window, 'new material' nodes can appear off-screen, as if nothing has been added.

Present behaviour (centre of node editor space highlighted)

Expected behaviour?

Zoomed and magnified view to help highlight the present 'new material' node placement

Above is not a complaint, (as mentioned) just something I've wondered about and not known where to ask until yesterday/today.
Thank you for your time,

David

Revisions and Commits

rB Blender
rB89025958af5f Fix T44921: Node editor, nodes position not maintained after Material panel…

Related Objects

Event Timeline

David Black (david_black) created this task.Jun 2 2015, 4:28 AM
David Black (david_black) raised the priority of this task from to 90.
David Black (david_black) updated the task description. (Show Details)
David Black (david_black) added a project: BF Blender.
David Black (david_black) edited a custom field.
David Black (david_black) added a subscriber: David Black (david_black).
Thomas Dinges (dingto) added a project: User Interface.Jun 2 2015, 7:09 AM
Thomas Dinges (dingto) added a subscriber: Thomas Dinges (dingto).
Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).Jun 2 2015, 9:35 AM

Placement of new nodes is a bit arbitrary. It could be improved for sure, but it's a bit tricky to do if we want to support both automated nodes editing and manual one. Surely it'll be improved, but not as a part of bugfixing.

Sergey Sharybin (sergey) changed the task status from Unknown Status to Resolved by committing rB89025958af5f: Fix T44921: Node editor, nodes position not maintained after Material panel….Jun 2 2015, 9:35 AM
Sergey Sharybin (sergey) added a commit: rB89025958af5f: Fix T44921: Node editor, nodes position not maintained after Material panel….
David Black (david_black) added a comment.Jun 4 2015, 1:33 AM

Wow that was quick!

Thank you for the rapid commit. Just tried the GNU/Linux version, massive improvement. :)

Thanks also for your feedback, appreciate improvements / modifications are not possible during Bcon4 bug-fix phase, just wondered about the points raised for a while and not known where to ask.

"Also improved a bit behaviour of adding new nodes, now they will not overlap that
badly. Still not ideal, but further improvements better not to happen at bcon4.". Interesting! :)

.

Considering future node editor improvements:

Rather than needing to rely on the Material panel to replace a node, what are peoples thoughts on adding Shift R function to the node editor?

Shift A add a node
Shift R replace a node (only functional if a single node is selected (works in exactly the same way as currently replacing a node using the Material panel))

Unless I've missed a similar function. Replacing a node can be faster than removing a node, adding a new node, reconnecting sockets and re-entering data.
On that last point, replacing a node carries over compatible exchangeable data, for example diffuse / glossy roughness values and so on (this helpful feature already happens while using the material panel).

Shift R also removes the need to search through collapsed Material panel node groups.

Oh! Just noticed (didn't spot before typing all the above), you already use Shift R, oh well, was a nice idea. :)

Thanks for your time,
David

Sergey Sharybin (sergey) added a comment.Jun 20 2015, 11:56 PM

For the further improvements the bug tracker is not best place actually. it all gets lost and because it's now becoming more a mixture of bug report and requests also not so easy to follow..

Please be welcome in bf-funboard (functional discussion mailing list) and #blendercoders IRC channel. That'd be easier to find more feedback about the features you want and even find a developer :)