Page MenuHome
Create Task
Maniphest T45168

FCurve editor: Inconsistent/unclear display of group visibility state
Confirmed, NormalPublicTO DO
Actions

Description

System Information
Win7/64, GTX 750 Ti

Blender Version
2.74 official

Short description of error


The group visibility icon (in red circle) makes no useful statement about the visibility of the contained channels.

Exact steps for others to reproduce the error

  1. Open
    FCurveVisibleState.blend56 KBDownload
  2. As you can see in the FCurve window, all three channels are visible (True), so is the group.
  3. If you click the visibility of the "X Location" channel in order to hide it, the group visibility is still True.
  4. If you additionally hide the Y and Z location, the group visibility state is still True.

This means that the group visibility icon is True if either all, some or none channels are visible. In other words, it does not reflect anything useful. It only acts as a button to toggle the state of the channels.

If the group icon is not to display an intermediate state (some but not all channels are visible), the True state should indicate that at least one channel is visible. Consequently, the only required change is: If no channel is visible, the group icon should also be set to False. Otherwise, if the group is collapsed and the group icon displays True, we always have to expand the group in order to find out if any channel is visible at all.

Event Timeline

Willi (willi) created this task.Jun 24 2015, 12:32 AM
Willi (willi) raised the priority of this task from to 90.
Willi (willi) updated the task description. (Show Details)
Willi (willi) added projects: BF Blender, User Interface.
Willi (willi) edited a custom field.
Willi (willi) added a subscriber: Willi (willi).
Bastien Montagne (mont29) assigned this task to Joshua Leung (aligorith).Jun 27 2015, 4:21 PM
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

Joshua, will also let you decide here. From this code comments:

	 * For Visibility:
	 *	- only flush up if the current state is now enabled (positive 'on' state is default) 
	 *	  (otherwise, it's too much work to force the parents to be inactive too)

…it looks like not flushing upward on turning off visibility is expected… :/

Bastien Montagne (mont29) lowered the priority of this task from 90 to 50.Jun 27 2015, 4:22 PM
Joshua Leung (aligorith) added a comment.Aug 6 2015, 4:46 PM

Ugh... this has always been dodgy to deal with.

One argument against having that toggle reflect the state of things is that sometimes not all FCurves in the same group will be visible in the channel list (i.e. name filtering), so you're going to get some funkiness there anyway.

On a side note, the new fmodifier on/off toggles behave oddly on FCurves. Probably some flushing logic gone wrong.

Julian Eisel (Severin) edited a custom field.Aug 6 2015, 5:02 PM
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).

Rather have this a design or to do task.

Julian Eisel (Severin) moved this task from Backlog to Short-Term Scope (Inactive) on the User Interface board.Sep 5 2020, 6:20 PM
Julian Eisel (Severin) moved this task from Short-Term Scope (Inactive) to Responsibility of Other Project/Module on the User Interface board.Oct 26 2020, 5:22 PM