Page MenuHome
Create Task
Maniphest T46320

New Depsgraph: Auto-IK doesn't work.
Closed, ResolvedPublic
Actions

Description

Blender 2.76-rc2 2eb0c99

Ubuntu 14.04 64x, nVidia GT620

Auto-IK doesn't work on new DEPSGRAPH

Open the file with new depsgraph and try to move the bone selected. You won't can.

With old depsgraph, it works.

79_depsgraph-auto-ik.blend452 KBDownload

Revisions and Commits

rB Blender
rB03e8202b7b19 Fix T46320: New Depsgraph: Auto-IK doesn't work

Related Objects

Event Timeline

Mario Mey (mariomey) created this task.Sep 29 2015, 4:53 PM
Mario Mey (mariomey) raised the priority of this task from to 90.
Mario Mey (mariomey) updated the task description. (Show Details)
Mario Mey (mariomey) added a project: Dependency Graph.
Mario Mey (mariomey) edited a custom field.
Mario Mey (mariomey) added a subscriber: Mario Mey (mariomey).
Aaron Carlisle (Blendify) added a project: BF Blender.Sep 29 2015, 4:57 PM
Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).
Sergey Sharybin (sergey) lowered the priority of this task from 90 to 50.Sep 30 2015, 9:37 AM
Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).

Can confirm the issue. Will look into it shortly.

Sergey Sharybin (sergey) claimed this task.Sep 30 2015, 9:38 AM
Sergey Sharybin (sergey) added subscribers: Joshua Leung (aligorith), Campbell Barton (campbellbarton).Nov 8 2015, 4:41 AM

Developer's note:

The issue is caused by transform tool temporary affecting on the pose constraints, which actually changes the way how pose is to be evaluated. Here's a patch which makes sure dependency graph is always up-to-date after such modifications:

{

P283 Fix T46320
1diff --git a/source/blender/editors/transform/transform_conversions.c b/source/blender/editors/transform/transform_conversions.c
2index 5898ad6..6bf9507 100644
3--- a/source/blender/editors/transform/transform_conversions.c
4+++ b/source/blender/editors/transform/transform_conversions.c
5@@ -845,6 +845,8 @@ static void pose_grab_with_ik_clear(Object *ob)
6 }
7 }
8 }
9+
10+ DAG_relations_tag_update(G.main);
11 }
12
13 /* adds the IK to pchan - returns if added */
14@@ -995,8 +997,10 @@ static short pose_grab_with_ik(Object *ob)
15 }
16
17 /* iTaSC needs clear for new IK constraints */
18- if (tot_ik)
19+ if (tot_ik) {
20 BIK_clear_data(ob->pose);
21+ DAG_relations_tag_update(G.main);
22+ }
23
24 return (tot_ik) ? 1 : 0;
25 }
}

Not sure if there's better approach to this problem. @Joshua Leung (aligorith), @Campbell Barton (campbellbarton), any ideas?

Campbell Barton (campbellbarton) added a comment.Nov 11 2015, 5:24 PM

@Sergey Sharybin (sergey), seems correct API usage and fine for master.

Note - calling into DAG directly seems a bit low level (we could have a version of BKE_pose_tag_recalc for this).

Sergey Sharybin (sergey) added a comment.Nov 12 2015, 3:50 PM

@Campbell Barton (campbellbarton), we can't only tag pose for recalc, nodes in depsgraph are to be updated to mimic updated armature settings. In theory it's possible to perform partial depsgraph topology update, but in practice it's quite tricky to do correct.

Sergey Sharybin (sergey) added a comment.Nov 12 2015, 3:55 PM

Sorry for the spam.

On another hand on a production scene full relations update could be rather too much costly to be performed on transform. Maybe there's some better trick to do.

Sergey Sharybin (sergey) changed the task status from Unknown Status to Resolved by committing rB03e8202b7b19: Fix T46320: New Depsgraph: Auto-IK doesn't work.Nov 12 2015, 4:20 PM
Sergey Sharybin (sergey) added a commit: rB03e8202b7b19: Fix T46320: New Depsgraph: Auto-IK doesn't work.
Sergey Sharybin (sergey) mentioned this in rBdf07303fbbe8: Depsgraph: Avoid unneeded relations update when canceling transform.May 9 2016, 4:04 PM