Page MenuHome
Create Task
Maniphest T46918

FileBrowser - get rid of useless operators like FILE_OT_hidedot.
Closed, ResolvedPublicTO DO
Actions

Description

System Information
Operating system and graphics card

Windows 7 home 64 Bit
Nvidia 760 gtx

Blender Version
Broken: (example: 2.69.7 4b206af, see splash screen)
Worked: (optional)

Short description of error

Not sure if this is a bug or a UI work in progress issue. I cannot change the hotkeys for the icon buttons in the top row of the file browser. The rmb menu doesn't contain a change or add shortcut menu item.

Exact steps for others to reproduce the error
Based on a (as simple as possible) attached .blend file with minimum amount of steps

Open Blender, go to the file browser. Right click at one of the buttons at the top. I have chosen the hide dot files button here. It has no rmb menu to add or to change the shortcut.

What we have though is shortcuts in the Input manager for some of them. But they use a completely different menu code from what i can see. And provides different tooltips. And when you add the buttons with using the Identifier from the Input nodes, then you can add a button that displays the tooltip, and has a rmb menu where you can change the hotkey.

Wouldn't it be better when the buttons would display the hotkey the tooltip? And would have the rmb menu to change the hotkey?

I have in the second image added such a button with the identifier from the input manager to the space_filebrowser.py file to show what i mean.

Revisions and Commits

rB Blender
rBa7dbc0704f21 Fix T46918: - Cleanup - FileBrowser - get rid of useless operators and update…

Related Objects

Event Timeline

Reiner Prokein (tiles) created this task.Dec 3 2015, 10:53 AM
Reiner Prokein (tiles) raised the priority of this task from to 90.
Reiner Prokein (tiles) updated the task description. (Show Details)
Reiner Prokein (tiles) added a project: BF Blender.
Reiner Prokein (tiles) edited a custom field.
Reiner Prokein (tiles) added a subscriber: Reiner Prokein (tiles).
Reiner Prokein (tiles) added a comment.Dec 3 2015, 11:15 AM

Okay, seems that i have catched with the show/hide dot files the one button of the row that has this behaviour ^^

The other buttons either have already the right code, or no shortcut at all. So it's just about the show/hide tot files button at the moment. It would nevertheless be nice to have the rmb menu with add and change hotkeys at the rest of the buttons too.

Bastien Montagne (mont29) claimed this task.Dec 3 2015, 11:59 AM
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).

Eeek! Having an operator for that is total overkill, this has to be replaced by generic WM_OT_context_toggle one!

Looks like filebrowser has quite a bunch of those, will clean that up.

That said, it won't solve the shortcut issue itself - for that we need a way to match generic WM_OT_context_foo operators with buttons that do direct access to RNA prop, this is more a TODO than a bug really.

Bastien Montagne (mont29) renamed this task from Can't display the shortcut in the tooltip and can't change hotkey at the icon buttons in the file browser to FileBrowser - get rid of useless operators like FILE_OT_hidedot..Dec 3 2015, 12:00 PM
Bastien Montagne (mont29) lowered the priority of this task from 90 to Normal.
Bastien Montagne (mont29) added a project: User Interface.
Bastien Montagne (mont29) edited a custom field.
Bastien Montagne (mont29) changed the task status from Unknown Status to Resolved by committing rBa7dbc0704f21: Fix T46918: - Cleanup - FileBrowser - get rid of useless operators and update….Dec 3 2015, 12:24 PM
Bastien Montagne (mont29) added a commit: rBa7dbc0704f21: Fix T46918: - Cleanup - FileBrowser - get rid of useless operators and update….
Bastien Montagne (mont29) mentioned this in rB80fa528529e2: Fix FileBrowser 'context-editing' properties shortcuts not being displayed in….Dec 3 2015, 12:51 PM