Page MenuHome
Create Task
Maniphest T48221

Blender cycles standalone does not read aa_samples from xml
Closed, ResolvedPublic
Actions

Description

Blender cycles standalone does not read aa_samples from xml. It is trivial to fix - simply add to cycles_xml.cpp:
xml_read_int(&integrator->aa_samples, node, "aa_samples");

Event Timeline

Tautvydas Andrikys (esminis) created this task.Apr 21 2016, 7:22 AM
Tautvydas Andrikys (esminis) raised the priority of this task from to 90.
Tautvydas Andrikys (esminis) updated the task description. (Show Details)
Tautvydas Andrikys (esminis) added a project: BF Blender.
Tautvydas Andrikys (esminis) edited a custom field.
Tautvydas Andrikys (esminis) added a subscriber: Tautvydas Andrikys (esminis).
Tautvydas Andrikys (esminis) added a comment.Apr 21 2016, 8:28 AM

Update: not sure but might be that aa_samples is taken from num_samples(from "--samples" parameter), if it is the case then can you confirm and dismiss this report

Bastien Montagne (mont29) assigned this task to Thomas Dinges (dingto).Apr 21 2016, 10:17 AM
Bastien Montagne (mont29) lowered the priority of this task from 90 to Normal.
Bastien Montagne (mont29) edited projects, added Cycles; removed BF Blender.
Bastien Montagne (mont29) added subscribers: Bastien Montagne (mont29), Sergey Sharybin (sergey), Thomas Dinges (dingto).
Thomas Dinges (dingto) changed the task status from Unknown Status to Resolved.Apr 21 2016, 3:36 PM

Yes, you should use the --samples parameter. This value is then used to set samples inside of SessionParams.