Page MenuHome
Create Task
Maniphest T52852

Assert in looptri calculation after recent changes
Closed, ResolvedPublic
Actions

Description

Latest master, debug build with tests enabled, while running cycles_report_test i'm hitting the following assert when running the T42475_1/2 tests.

62: BLI_assert failed: K:\BlenderGit\blender\source\blender\blenkernel\intern\cdderivedmesh.c:1922, CDDM_recalc_looptri(), at 'cddm->dm.looptris.array_wip != ((void *)0)'
62: [ RUN      ] T42475_1
62: 31: BLI_system_backtrace - 0x41404610
62: 30: CDDM_recalc_looptri - 0x40F63C10
62: 29: dm_getLoopTriArray - 0x40EEBAC0
62: 28: cloth_from_mesh - 0x40FFDFA0
62: 27: cloth_from_object - 0x40FFE160
62: 26: do_init_cloth - 0x41000830
62: 25: clothModifier_do - 0x40FFD200
62: 24: do_hair_dynamics - 0x40F12BC0
62: 23: hair_step - 0x40F12FB0
62: 22: particle_system_update - 0x40F07940
62: 21: deformVerts - 0x409C3330
62: 20: modwrap_deformVerts - 0x40D65AC0
62: 19: mesh_calc_modifiers - 0x40EECCC0
62: 18: mesh_build_data - 0x40EEF480
62: 17: makeDerivedMesh - 0x40EE4AA0
62: 16: BKE_object_handle_data_update - 0x41030480
62: 15: BKE_object_handle_update_ex - 0x40E7EF60
62: 14: scene_update_object_func - 0x40DB3690
62: 13: BLI_task_pool_work_and_wait - 0x41450110
62: 12: scene_update_objects - 0x40DB3BC0
62: 11: scene_update_tagged_recursive - 0x40DB3E00
62: 10: BKE_scene_update_tagged - 0x40DB0A60
62: 9: wm_file_read_post - 0x3FFB5AD0
62: 8: WM_file_read - 0x3FFB2910
62: 7: arg_handle_load_file - 0x3FFAE370
62: 6: BLI_argsParse - 0x413FECA0
62: 5: main_args_setup_post - 0x3FFAAA40
62: 4: main - 0x3FFA92A0
62: 3: __tmainCRTStartup - 0x451425A0
62: 2: mainCRTStartup - 0x451427C0
62: 1: BaseThreadInitThunk - 0x772459C0
62: 0: RtlUserThreadStart - 0x7737A540
62: BLI_assert failed: K:\BlenderGit\blender\source\blender\blenkernel\intern\cdderivedmesh.c:1922, CDDM_recalc_looptri(), at 'cddm->dm.looptris.array_wip != ((void *)0)'
[... couple hundred lines of stackdumps...]
62: [       OK ] T42475_1 (8799 ms)

yet the test still gets marked as a 'pass'

full log:

cycles_report.txt51 KBDownload

Revisions and Commits

rB Blender
Needs ReviewD2850 Windows: for background mode, don't show error popups for crashes.
rB25f28d348fe1 Fix T52852: Assert in looptri calculation after recent changes.

Related Objects

Event Timeline

Ray Molenkamp (LazyDodo) created this task.Sep 20 2017, 5:36 PM
Ray Molenkamp (LazyDodo) assigned this task to Sergey Sharybin (sergey).Sep 20 2017, 7:16 PM
Brecht Van Lommel (brecht) reassigned this task from Sergey Sharybin (sergey) to Bastien Montagne (mont29).Sep 20 2017, 8:11 PM
Brecht Van Lommel (brecht) lowered the priority of this task from 90 to 50.
Brecht Van Lommel (brecht) added subscribers: Sergey Sharybin (sergey), Brecht Van Lommel (brecht).

This is new code from rB9591b5f6182f: Fix T52816: regression can't open file in 2.79 (crash)..

Just open the .blend and it will show that backtrace already, no need to start a Cycles render:

T42475_1.blend945 KBDownload

Brecht Van Lommel (brecht) renamed this task from [Ctest/cycles_report_test] Assert fires, test still succeeds. to Assert in looptri calculation after recent changes.Sep 20 2017, 8:12 PM
Brecht Van Lommel (brecht) edited projects, added BF Blender; removed Restricted Project, Cycles.
Ray Molenkamp (LazyDodo) added a comment.Sep 20 2017, 8:14 PM

While the assert might not be auto testing related I really wish that this test wasn't marked as a pass, if i hadn't been randomly paying attention to the terminal, this would have just scrolled by and marked as a 'pass'

Brecht Van Lommel (brecht) added a comment.Sep 20 2017, 8:39 PM

Right, it will only crash when building with WITH_ASSERT_ABORT. Not sure what the best way is to solve that, perhaps a --debug-abort command line option to enable aborting at runtime?

Bastien Montagne (mont29) added a comment.Sep 20 2017, 8:40 PM

Our asserts by default do not error, only print the warning, autotest has nothing to do with that… There is a switch to actually abort on failed asserts iirc, could be useful to enable it for testing (can't remember exactly how, build option, envvar, …).

Assert is just wrong here btw, fix incomming.

Ray Molenkamp (LazyDodo) added a comment.Sep 20 2017, 8:48 PM

There seems to be some varying behavior with asserts. This one silently failed while marking the test as succeeded, T52853 displayed a popup (abort to quit, retry to debug, ignore to carry on) which blocked further tests from running, given running ctest on a debug build took around 2 hours, not having to baby sit incase any ui shows up would be prefered. I'm not overly picky with any changes here, if WITH_ASSERT_ABORT does the trick i'll happily add that to my debug builds.

Bastien Montagne (mont29) changed the task status from Unknown Status to Resolved by committing rB25f28d348fe1: Fix T52852: Assert in looptri calculation after recent changes..Sep 20 2017, 8:48 PM
Bastien Montagne (mont29) added a commit: rB25f28d348fe1: Fix T52852: Assert in looptri calculation after recent changes..
Brecht Van Lommel (brecht) added a revision: D2850: Windows: for background mode, don't show error popups for crashes..Sep 20 2017, 9:12 PM
Brecht Van Lommel (brecht) added a comment.Sep 20 2017, 9:15 PM

The difference is that Cycles uses the standard assert() which will abort, while Blender uses BLI_assert() which doesn't. I guess building with WITH_ASSERT_ABORT is ok. For the popups D2850 is a solution.