Page MenuHome
Create Task
Maniphest T53109

Denoising passes; Variance pass output broken in recent builds
Closed, ResolvedPublic
Actions

Description

System Information
Win64 bit, i7 3770 processor, 24 gigs RAM, AMD 7700 GPU

Blender Version
Broken: hash 9f8bb58 (October 2)
Worked: hash 83ce028 (October 7)

Short description of error
I'll let the image describe it

The variance denoise passes are broken, they are no longer calculating the actual variance (so now it's just like the regular versions of the pass with different color values).

Exact steps for others to reproduce the error
Render the scene in an older build, check the pass info. Render the scene in a newer build, check the pass info.

.blend

Brokenpasses.blend503 KBDownload

Revisions and Commits

rC Cycles
rCca8f3cce9315 Fix T53109: denoising variance debug passes not working after recent changes.
rB Blender
rB3df2e6d76bc7 Fix T53109: denoising variance debug passes not working after recent changes.

Related Objects

Event Timeline

Adam Friesen (ace_dragon) created this task.Oct 19 2017, 11:43 PM
Sergey Sharybin (sergey) assigned this task to Brecht Van Lommel (brecht).Oct 20 2017, 10:58 AM
Sergey Sharybin (sergey) lowered the priority of this task from 90 to 50.
Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).

Caused by rB12f4538. Worth adding a regression test for this i'd say.

Brecht Van Lommel (brecht) changed the task status from Unknown Status to Resolved by committing rB3df2e6d76bc7: Fix T53109: denoising variance debug passes not working after recent changes..Oct 20 2017, 2:49 PM
Brecht Van Lommel (brecht) added a commit: rB3df2e6d76bc7: Fix T53109: denoising variance debug passes not working after recent changes..
Brecht Van Lommel (brecht) added a subscriber: Lukas Stockner (lukasstockner97).EditedOct 20 2017, 2:50 PM

Note:

  • These are passes for debugging the denoiser, enabled with the experimental feature set.
  • The result for OpenCL renders was already like this.
  • The denoiser itself is working fine, the meaning of the passes just changed for CPU and CUDA.

Now it outputs the actual variance again since that's more useful to visualize for debugging.

Sergey Sharybin (sergey) added a commit: rCca8f3cce9315: Fix T53109: denoising variance debug passes not working after recent changes..Oct 31 2017, 4:37 PM