Page MenuHome
Create Task
Maniphest T54899

Custom property -> revert to default value crashes blender
Closed, ResolvedPublic
Actions

Description

System Information
Win 10 - 5820K - GTX 970

Blender Version
Current daily build + 2.79b

Short description of error
If you revert a custom property back to default value when it is a string it (can) crash Blender

Exact steps for others to reproduce the error

  1. Start blender
  2. Add custom property to default cube (bottom of object settings panel)
  3. Select Edit
  4. Change the property value so it is now a string: eg change to "Crash"
  5. Click OK
  6. Now right click and select revert to default value.
  7. Crash

Related Objects

Event Timeline

Rob Hughes (RevDr) created this task.Apr 30 2018, 4:09 PM
Philipp Oeser (lichtwerk) claimed this task.Apr 30 2018, 4:27 PM
Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Confirmed, will have a look (soonish)

Philipp Oeser (lichtwerk) added a comment.May 2 2018, 3:13 PM

crash is here (when blender tries to determine the default value for the string -- sprop>defaultvalue is NULL though...)

1  __strlen_avx2                                                    0x7fffece62c11 
2  RNA_property_string_default_length    rna_access.c         3087  0x27a681b      
3  RNA_property_string_get_default_alloc rna_access.c         3068  0x27a673d      
4  RNA_property_reset                    rna_access.c         6989  0x27b0a00      
5  reset_default_button_exec             interface_ops.c      268   0x1ba4ebe      
6  wm_operator_invoke                    wm_event_system.c    1151  0x180f334      
7  wm_operator_call_internal             wm_event_system.c    1372  0x180fac4      
8  WM_operator_name_call_ptr             wm_event_system.c    1384  0x180fb72      
9  ui_apply_but_funcs_after              interface_handlers.c 795   0x1b7c26e      
10 ui_popup_handler                      interface_handlers.c 10213 0x1b957c8      
11 wm_handler_ui_call                    wm_event_system.c    474   0x180d729      
12 wm_handlers_do_intern                 wm_event_system.c    2111  0x18117e9      
13 wm_handlers_do                        wm_event_system.c    2195  0x1811a97      
14 wm_event_do_handlers                  wm_event_system.c    2481  0x1812737      
15 WM_main                               wm.c                 522   0x1805dfe      
16 main                                  creator.c            539   0x1800822

Note this also happens when the Custom Property is created directly by python [but it seems the UI is actually doing it with python as well...]

So, havent (yet) figured out why this is not initialized properly, crash gets prevented by P669 though

Philipp Oeser (lichtwerk) changed the task status from Unknown Status to Resolved.Feb 1 2019, 10:27 PM

This is resolved in 2.8 (current master).
Havent tracked down the exact commit (I assume this is rB61c941f040d3)

2.79 branch is still crashing, but don think this will be backported...

Philipp Oeser (lichtwerk) mentioned this in T69332: Crash : attempting to reset a a custom property that has a string value crashes Blender.Sep 2 2019, 11:59 AM