Page MenuHome
Create Task
Maniphest T58735

Incorrect workbench shadow from n-gons
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Windows 10
Graphics card: GTX 1080Ti

Blender Version
Broken: 2.80, a205493426b, 2018-12-03

Short description of error
Workbench shadows are often incorrect on n-gons. I have yet to reproduce this in a simple start file, but I'm seeing it all the time in more complex scenes.

Exact steps for others to reproduce the error

  1. Open the attached file:

door_10_modeling_test_shadow-error.blend1 MBDownload

  1. Create an n-gon out of the selected faces.

Video: http://recordit.co/mo0NCM8V0N

You can also see them on the objects Plane and Circle.002:

Revisions and Commits

rB Blender
rB3dfbb72b296a Workbench: Fix shadow artifact caused by degenerate triangles

Related Objects

Event Timeline

Jonathan Lampel (jonathanl) created this task.Dec 4 2018, 8:18 PM
Dalai Felinto (dfelinto) lowered the priority of this task from 90 to 50.Dec 4 2018, 9:16 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

Confirmed, and simplified the file to a minimum:

ngon-shadow.blend118 KBDownload

Note: If you flip the normals, the shadow changes (it is still a wrong shadow).

Dalai Felinto (dfelinto) assigned this task to Clément Foucault (fclem).Dec 4 2018, 9:40 PM
Dalai Felinto (dfelinto) added a subscriber: Clément Foucault (fclem).

Assigning to @Clément Foucault (fclem) although he is a bit skeptical of whether we can fix this since the shadow technique is not meant to work with those kind of (internally generated) triangles.
In fact I managed to reproduce this regardless of ngons:

2-tris.blend122 KBDownload

Clément Foucault (fclem) changed the task status from Unknown Status to Resolved by committing rB3dfbb72b296a: Workbench: Fix shadow artifact caused by degenerate triangles.Dec 11 2018, 1:25 AM
Clément Foucault (fclem) added a commit: rB3dfbb72b296a: Workbench: Fix shadow artifact caused by degenerate triangles.