System Information
Operating system:
Windows 10 x64
Graphics card:
Nvidia Geforce GTX 1080Ti
Blender Version
Broken: 2.80, 7d4d9e9dbd3
Short description of error
The Search in the View Layer drop down menu isn´t working
Exact steps for others to reproduce the error
Open the attached blend file.
Open the View Layer popup and write "Test" into the search field. Nothing happens.
The first View Layer ist called test.
| rB Blender | |||
| rBfc74903f272a Fix T59322: View Layer - Search not working | |||
Basically when we get to ui_rna_collection_search_cb skip_filter is always true because in those cases data->but_changed is NULL for those buttons.
Tempted to remove the skip_filter altogether, or at least to never skip when there is no but_changed.
For the records, this works: P870
The way we are using this "but_changed" seems wrong anyways.
@Brecht Van Lommel (brecht) are you familiar with this code? Have any opinion around which way to go?
I hadn't seen this code before.
To me it seems but_changed should be removed, and filtering should only depend on str being empty or not.
Although, I guess but_changed is needed for the case there is already a value in the text field, like when clicking to select a different bone?
In the search menu probably always setting it to true is ok as a fix.