System Information
Operating system: Win10
Graphics card: GeforceGTX950
Blender Version
2.80, dc3b5024be1a4, 2019-01-23, win64
Blender sometimes crashs by pressing Ctrl+Z directly after a mesh renamed (in my case Cube.001)
SysInfo:
Description
Description
Revisions and Commits
Revisions and Commits
Related Objects
Related Objects
- Mentioned In
- rB59a0a143ddb5: Library: tag memfile undo for writing after rename
T60660: TEXTURE PAINT tab BUG- Undo a simple PAINT operation using CTRL-Z and it removes entire TEXTURE IMAGE-Workarounds and Thorough Steps to Repeatability BELOW. - Mentioned Here
- T56163: Improve MemFile Undo (for general use)
Event Timeline
Comment Actions
This fixes the problem. But I'm not sure whether meshedit_undo should be handling this in the first place.
diff --git a/source/blender/blenkernel/intern/undo_system.c b/source/blender/blenkernel/intern/undo_system.c index 12cd8fc43e9..c2a814128af 100644 --- a/source/blender/blenkernel/intern/undo_system.c +++ b/source/blender/blenkernel/intern/undo_system.c @@ -126,8 +126,6 @@ static void undosys_id_ref_store(void *UNUSED(user_data), UndoRefID *id_ref) BLI_assert(id_ref->name[0] == '\0'); if (id_ref->ptr) { BLI_strncpy(id_ref->name, id_ref->ptr->name, sizeof(id_ref->name)); - /* Not needed, just prevents stale data access. */ - id_ref->ptr = NULL; } }
Comment Actions
@matc (matc), this only works in the simple case, it wont work if a memfile undo step as been loaded.
On Friday I looked into possible fixes for this:
Some options are:
- Add memfile undo pushes when renaming.
- Use something besides the name (eg, a UUID) for each ID instead of it's name.
- Use memfile undo for all modes and optimize it to remove the need for different undo systems (see: T56163).
I'll try some solutions this week in a branch and post any updates here.