Page MenuHome

make update_po failed
Closed, ResolvedPublic

Description

After performed:

svn update .

at the 'blender_docs' directory, to bringing latest changes in the documentation, if you then run

export LC_ALL=C.UTF-8; export LANG=C.UTF-8; make update_po

you will get this error:

svn: warning: W150002: '/home/htran/blender_documentations/blender_docs/locale/vi' is already under version control
svn: E200009: Could not add all targets because some targets are already versioned
svn: E200009: Illegal target for the requested operation

Error(1) on line 77, in command:
svn add $NEW_DIRS

Makefile:165: recipe for target 'update_po' failed
make: [update_po] Error 1 (ignored)

and it's down to the line above mentioned line of code 'svn add $NEW_DIRS' in the following section of code:

  1. note, the Python part filters only for directories
  2. there may be a cleaner way to do this in shell.

NEW_DIRS=svn status . | grep -v -e "\.po$" | awk '/^[?]/{print $2}' | python -c "import sys, os; sys.stdout.write('\n'.join([f for f in sys.stdin.read().split('\n') if os.path.isdir(f)]))"
if [ "$NEW_DIRS" != "" ]; then

  1. Multiple args, don't quote.

svn add $NEW_DIRS
fi
unset NEW_DIRS

from the file

blender_docs/tools_maintenance/update_po.sh

Printing a few debug lines out and it comes down to the

'locale/<language>'

that was found, but this directory is already under 'svn' control for translation and it has NOTHING to do with manual repository. The following line fixed the problem:

if [ "$NEW_DIRS" != "" && "$NEW_DIRS" != "$LANG" ]; then

Event Timeline

Aaron Carlisle (Blendify) lowered the priority of this task from 90 to Low.

Note that this is working for me, most likely a difference in my svn checkout which holds all languages. in locale/

I also have all the languages and works for me.

Would that then be the location of '.svn' directory? I have this under 'locale/vi'. Yours are probably in 'locale'??? I've followed the instruction in the manual

https://docs.blender.org/manual/en/dev/about/contribute/translations/contribute.html

and clone the svn of translation as:

svn checkout https://svn.blender.org/svnroot/bf-manual-translations/trunk/blender_docs/locale/vi locale/vi

As a language translator, I don't think the existence of other languages are necessary, and thus did not download the whole set of languages to my local HDD.

Right, this is a problem with the script that needs to be fixed.

Sorry to have raised this again, tested tonight and it doesn't work, failed on the line:

svn add $NEW_FILES

Added for loop to perform 'svn add' on single instance of new files appeared to work:

Please correct this. Thank you.

By the way, I won't update the locale/vi repository so you can download to your local HDD to test, using:

cd blender_docs
rm -fr locale
svn checkout https://svn.blender.org/svnroot/bf-manual-translations/trunk/blender_docs/locale/vi locale/vi > /dev/null
export LC_ALL=C.UTF-8; export LANG=C.UTF-8; make update_po

Hoang Duy Tran (hoangduytran) changed the task status from Resolved to Unknown Status.Jun 30 2019, 1:31 AM

Could you try again, this should be fixed rBM5298.

OK, I'm waiting for some more changes on the repository to test later. I had a gut that it's down to command line buffer's limit. Look at the cut off of the last-line in the screenshot of the error.

Hoang Duy Tran (hoangduytran) changed the task status from Unknown Status to Resolved.Jul 2 2019, 11:27 AM

Ran test to 'make update_po' today and it appeared working. Closing this log as resolved for the moment.