Page MenuHome
Create Task
Maniphest T66591

Grease Pencil layer visibility control via driver(using distance between two objects)
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: macOS High Sierra (version 10.13.6{F7578376}
Graphics card: NVIDIA GeForce GT 750M OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-10.32.0 355.11.10.10.40.102

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-07 23:53, hash: rBbb2abacb4b5c
Worked: (optional)

Short description of error
Hey guys having a bit of a issue with blender grease pencil layer visibility.
-I am trying to control the visibility of grease pencil layer via driver using the distance between two objects.It is working in render and layers panel ,but not in the viewport. It doesnot get updated in viewport.Please fix.

-Mouse pointer is back in draw mode

Other than that GREAT WORK guys. BLENDER 2.8 is awesome.

Happy Blending.

Exact steps for others to reproduce the error
-add a grease pencil stroke
-draw anything
-go to layers panel of grease pencil
-add a driver
-add two objects to control visibility of Grease Pencil layer via distance.

Revisions and Commits

rB Blender
rB58b554c7a4f8 Fix T66591: GPencil layer visibility control via driver doesn't work

Related Objects

Event Timeline

Abin Shahi (xxpiratexxg695) created this task.Jul 9 2019, 6:54 AM
Abin Shahi (xxpiratexxg695) updated the task description. (Show Details)Jul 9 2019, 7:01 AM
Germano Cavalcante (mano-wii) lowered the priority of this task from 90 to 30.EditedJul 9 2019, 1:54 PM
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

We require a .blend file and simple steps to reproduce the problem.
We currently have many bugs to keep track of.
It is not good for the developer for whom this bug is assigned to spend a lot of time trying to replicate it.
A guideline for making a good bug report can be found here: https://wiki.blender.org/wiki/Process/Bug_Reports

Abin Shahi (xxpiratexxg695) added a comment.Jul 10 2019, 5:01 AM

System Information
Operating system: macOS High Sierra (version 10.13.6{F7578376}
Graphics card: NVIDIA GeForce GT 750M OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-10.32.0 355.11.10.10.40.102

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-07 23:53, hash: rBbb2abacb4b5c
Worked: (optional)

Short description of error
Hey guys having a bit of a issue with blender grease pencil layer visibility.
-I am trying to control the visibility of grease pencil layer via driver using the distance between two objects.It is working in render and layers panel, and is working after you set key,but It does not get live update in viewport.Please fix.

GP_bug.blend1 MBDownload

-Mouse pointer is back in draw mode

Other than that GREAT WORK guys. BLENDER 2.8 is awesome.

Happy Blending.

Exact steps for others to reproduce the error
-add a grease pencil stroke
-draw anything
-go to layers panel of grease pencil
-add a driver
-add two objects to control visibility of Grease Pencil layer via distance.
-move object to turn on/off the grease pencil stroke

Bastien Montagne (mont29) raised the priority of this task from 30 to 80.Jul 23 2019, 3:37 PM
Bastien Montagne (mont29) added a project: Grease Pencil.
Antonio Vazquez (antoniov) lowered the priority of this task from 80 to 50.Jul 23 2019, 5:30 PM
Antonio Vazquez (antoniov) added subscribers: Bastien Montagne (mont29), Sergey Sharybin (sergey), Antonio Vazquez (antoniov).

I can reproduce the problem and I guess what it's the reason.

When you set the layer as hidden in the layer list, the property "hide" is changed and the rna_GPencil_update function is called to tag the GPU cache and recalc the view data, but when the property is changed using the driver the property is changed but the datablock is not tagged and the screen is not updated. I have run a debug and the rna_update function is not called.

It's easy to verify, after moving the sphere to set as hide, just move the frame in the timeline and the screen is refreshed because the GPU data is tagged and updated. The solution is tag the gpd datablock

Something like:

bGPdata *gpd = (bGPdata *)ob->data;
DEG_id_tag_update(&gpd->id, ID_RECALC_GEOMETRY);
WM_main_add_notifier(NC_GPENCIL | NA_EDITED, NULL);

No idea where to fix this, maybe @Bastien Montagne (mont29) or @Sergey Sharybin (sergey) have any idea.

Sergey Sharybin (sergey) added a comment.Jul 23 2019, 5:40 PM

@Antonio Vazquez (antoniov), this sounds like a missing relation in the dependency graph. Can you give me a very simple file with minimal possible entities involved to reproduce the issue?

Antonio Vazquez (antoniov) added a comment.Jul 23 2019, 5:41 PM

@Sergey Sharybin (sergey) you have a very simple file in the task (see above)

Sergey Sharybin (sergey) claimed this task.Jul 23 2019, 6:32 PM

Ah, missed that. Indeed seems simple setup to debug :)

Sergey Sharybin (sergey) changed the task status from Unknown Status to Resolved by committing rB58b554c7a4f8: Fix T66591: GPencil layer visibility control via driver doesn't work.Jul 30 2019, 10:28 AM
Sergey Sharybin (sergey) added a commit: rB58b554c7a4f8: Fix T66591: GPencil layer visibility control via driver doesn't work.
Abin Shahi (xxpiratexxg695) added a comment.Jul 30 2019, 7:39 PM

:(

was really looking forward for this fix.

anyways congrats on official release. cheers developers ?