Page MenuHome
Create Task
Maniphest T67939

Grease Pencil Noise modifier step is ignored in render
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Darwin-18.7.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 570 OpenGL Engine ATI Technologies Inc. 4.1 ATI-2.11.20

Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-24 14:22, hash: rB507ffee6e1f4
Worked: (optional)

Short description of error
setting noise step to 6 should update the noise value every 6 frame. In render this value is ignored and updated (seemingly interpolated) each frame.

Exact steps for others to reproduce the error
open the attached blend file and play the animation in viewport. The noise on the stroke will be updated correctly. Then render the sequence and look at the result.

test_GP_noise_render.blend776 KBDownload

Revisions and Commits

rB Blender
D5393rB80123efc5fc2 Fix T67939: GPencil Noise modifier wrong random calculation
rB9d7a03ab1177 Fix T67939: GPencil Noise modifier step is ignored in render

Related Objects

Event Timeline

Ivan Cappiello (icappiello) created this task.Jul 30 2019, 3:14 PM
Ivan Cappiello (icappiello) added a project: Grease Pencil.Jul 30 2019, 3:17 PM
Ivan Cappiello (icappiello) updated the task description. (Show Details)Jul 30 2019, 3:21 PM
Ivan Cappiello (icappiello) added a subscriber: Daniel Martinez Lara (pepeland).
Ivan Cappiello (icappiello) assigned this task to Antonio Vazquez (antoniov).Jul 30 2019, 3:27 PM
Antonio Vazquez (antoniov) changed the task status from Unknown Status to Resolved by committing rB9d7a03ab1177: Fix T67939: GPencil Noise modifier step is ignored in render.Jul 30 2019, 7:43 PM
Antonio Vazquez (antoniov) added a commit: rB9d7a03ab1177: Fix T67939: GPencil Noise modifier step is ignored in render.
Ivan Cappiello (icappiello) added a comment.EditedJul 31 2019, 4:02 PM

@Antonio Vazquez (antoniov) after applying your patch the interpolation is gone but the noise still behaves very different from viewport and render. In render seems to just pop to the same noise value each step and then pop back to no noise value.
Can you please compare viewport and video render output to check if this is working as intended?

viewport:

render output:

Antonio Vazquez (antoniov) changed the task status from Resolved to Unknown Status.Jul 31 2019, 4:37 PM

It's strange...in my PC is not working equal... I will look again.

Antonio Vazquez (antoniov) lowered the priority of this task from 90 to Normal.Jul 31 2019, 4:37 PM
Antonio Vazquez (antoniov) added a comment.Aug 1 2019, 10:55 AM

I have redesign how the noise random values work in D5393.

Antonio Vazquez (antoniov) changed the task status from Unknown Status to Resolved by committing rB80123efc5fc2: Fix T67939: GPencil Noise modifier wrong random calculation.Aug 1 2019, 6:12 PM
Antonio Vazquez (antoniov) added a commit: rB80123efc5fc2: Fix T67939: GPencil Noise modifier wrong random calculation.