Page MenuHome
Create Task
Maniphest T71374

Node group discrepancies between EEVEE and Cycles
Closed, ResolvedPublicBUG
Actions

Description

Blender Version
Broken: 2.82, master, ece4515fc8aa, 2019-11-04
Worked: Never

Description
Plugging a Vector/Colour into a Scalar node group input produces a Scalar output in cycles, however in EEVEE it remains a vector.
I understand this is due to node group optimisations in Cycles, while in EEVEE node groups "disappear" during shader compilation.
I don't know which behaviour is preferred, but I assume there would be some small performance impact if every node group input/output was cast to it's respective type in the generated GLSL, so maybe a conditional check to see if the inputs match the expected type?

Steps to reproduce:
Left is LookDev/EEVEE, right is Cycles.

nodegrouptypes.blend556 KBDownload

Revisions and Commits

rB Blender
rBc2e21b232963 Fix T71374 EEVEE: Fix Node group socket not converting inputs as in Cycles

Related Objects

Event Timeline

Chris Clyne (lateasusual) created this task.Nov 6 2019, 12:17 AM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Nov 6 2019, 12:55 AM

Could you please attach a sample file?

Chris Clyne (lateasusual) added a comment.Nov 6 2019, 1:37 AM

Here you go, everything as defaults aside from the creation of that node group

nodegrouptypes.blend556 KBDownload

Brecht Van Lommel (brecht) lowered the priority of this task from 90 to Low.Nov 6 2019, 3:09 PM
Brecht Van Lommel (brecht) added a project: Eevee.
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Nov 6 2019, 3:20 PM

I think this is to be solved in Eevee, if a link goes to a different socket type it should convert.

Dalai Felinto (dfelinto) updated the task description. (Show Details)Nov 6 2019, 4:22 PM
Dalai Felinto (dfelinto) added a project: Tracker Curfew.Dec 23 2019, 1:44 PM
Clément Foucault (fclem) claimed this task.Jan 23 2020, 5:41 PM
Clément Foucault (fclem) changed the subtype of this task from "Report" to "Bug".
Clément Foucault (fclem) removed a project: Tracker Curfew.
Clément Foucault (fclem) closed this task as Resolved by committing rBc2e21b232963: Fix T71374 EEVEE: Fix Node group socket not converting inputs as in Cycles.Jan 23 2020, 9:41 PM
Clément Foucault (fclem) added a commit: rBc2e21b232963: Fix T71374 EEVEE: Fix Node group socket not converting inputs as in Cycles.
Clément Foucault (fclem) edited projects, added EEVEE & Viewport; removed Eevee.Jun 19 2020, 11:25 PM