Page MenuHome
Create Task
Maniphest T71882

Offset Edge Slide doesn't switch selection mode correctly
Closed, ResolvedPublicBUG
Actions

Description

Blender Version
Broken: 2.79b, 2.80, 2.81, 2.82 (ba1e9ae4733a)

Short description of error
Unlike Loop Cut that seems to do it, Offset Edge Slide does not switch selection mode correctly when used in face select mode. Even though current selection mode appears to switch to Edge, edge highlighting remains as if current mode was Face, both for selected and unselected edges.

Exact steps for others to reproduce the error

  1. Load the default scene
  2. Enter edit mode on the cube and switch to Face selection mode
  3. Select two opposite faces
  4. Use the Offset Edge Slide tool (either the active one or via shortcut)

Edge highlighting will remain as if selection mode hasn't changed. See image below

Revisions and Commits

rB Blender
AbandonedD6335 Fix T71882: Offset Edge Slide doesn't switch selection mode correctly
rBeaa21df5051c Fix T71882: Offset Edge Slide doesn't switch selection mode

Related Objects

Event Timeline

Stanislav Blinov (radcapricorn) created this task.Nov 25 2019, 10:26 AM
Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 30.Nov 25 2019, 10:38 AM
Philipp Oeser (lichtwerk) added a project: Modeling.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Cannot really reproduce here (I am ending up in edge select mode):


I assume you have checked this with Factory Defaults? [no Addons?]

Stanislav Blinov (radcapricorn) added a comment.EditedNov 25 2019, 10:43 AM

Well, hm, yes indeed, you're correct. Edge mode is set. But I'm not understanding the selection color for the new edges. Usually this happens when edges get selected in face mode (without edge mode enabled). I.e. on your torus, if you switch to vertex mode and back, selection will become highlighted properly.

Stanislav Blinov (radcapricorn) renamed this task from Offset Edge Slide doesn't switch to edge selection mode if used in face selection mode to Offset Edge Slide doesn't switch selection mode correctly.Nov 25 2019, 12:03 PM
Stanislav Blinov (radcapricorn) updated the task description. (Show Details)
Philipp Oeser (lichtwerk) raised the priority of this task from 30 to 80.Nov 25 2019, 12:07 PM

needs another look...

Anthony Edlin (krash) added a subscriber: Anthony Edlin (krash).Nov 25 2019, 5:54 PM

I also can not reproduce. It always seems to have edge mode set once I use Offset Edge Slide.

Linux-5.3.0-20-generic-x86_64-with-Ubuntu-18.04-bionic 64 Bits
GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.26
2.82 (sub 1), branch: master, commit date: 2019-11-25 15:12, hash: rB78071d0cdfe5

Stanislav Blinov (radcapricorn) added a comment.Nov 25 2019, 6:29 PM

Yes, the mode is set to Edge. But compare how it looks after using Loop Cut vs. Offset Edge Slide, when starting from Face mode:

Anthony Edlin (krash) added a comment.Nov 25 2019, 8:18 PM

Yes I see the edges are colored as if it was in vert mode and highlighting the edges.

Anthony Edlin (krash) added a comment.Nov 30 2019, 8:53 PM

Ok I looked into this a little bit. Current code doesn't change scenes tool settings from face to edge, only the edit meshes selectmode. Think we can safely use EDBM_selectmode_disable_multi to just always disable face select mode if this tool is used, much like the loopcut tool.

Made a patch and put it on Differential here: D6335: Fix T71882: Offset Edge Slide doesn't switch selection mode correctly

Richard Antalik (ISS) changed the task status from Needs Information from Developers to Confirmed.Jan 16 2020, 4:14 PM
Richard Antalik (ISS) updated the task description. (Show Details)
Richard Antalik (ISS) added a subscriber: Richard Antalik (ISS).
Bastien Montagne (mont29) changed the subtype of this task from "Report" to "Bug".Jan 20 2020, 8:37 PM
Germano Cavalcante (mano-wii) added a revision: D6335: Fix T71882: Offset Edge Slide doesn't switch selection mode correctly.Feb 10 2020, 8:08 PM
Campbell Barton (campbellbarton) closed this task as Resolved by committing rBeaa21df5051c: Fix T71882: Offset Edge Slide doesn't switch selection mode.May 12 2020, 6:41 AM
Campbell Barton (campbellbarton) claimed this task.
Campbell Barton (campbellbarton) added a commit: rBeaa21df5051c: Fix T71882: Offset Edge Slide doesn't switch selection mode.