Page MenuHome
Create Task
Maniphest T71909

GPencil: Any keyframed GPLayer property is not updated when render animation.
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Darwin-17.7.0-x86_64-i386-64bit 64 Bits
Graphics card: NVIDIA GeForce GTX 770 OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-10.33.0 387.10.10.10.40.130

Blender Version
Broken: version: 2.82 (sub 1), branch: master, commit date: 2019-11-24 14:51, hash: rB249f4423ee1c

Short description of error
Keyframing the Stroke Thickness setting, or any other property at Layer levels works as expected in the viewport, but isn't taken into account when rendering the animation.

If you render Frame by Frame works perfect.

Exact steps for others to reproduce the error
Play animated stroke in viewport and compare with a render of the animation.

GP-stroke-thickness-render-test.blend712 KBDownload

Revisions and Commits

rB Blender
rB9ecc30250aae Fix T71909: Any keyframed GPLayer property is not updated when render animation

Event Timeline

Bolos (Bolos) created this task.Nov 26 2019, 12:49 AM
Bolos (Bolos) updated the task description. (Show Details)
Bolos (Bolos) added a project: Grease Pencil.
Antonio Vazquez (antoniov) assigned this task to Sergey Sharybin (sergey).Nov 26 2019, 11:08 AM
Antonio Vazquez (antoniov) lowered the priority of this task from 90 to 50.
Antonio Vazquez (antoniov) added a project: Dependency Graph.
Antonio Vazquez (antoniov) added subscribers: Sergey Sharybin (sergey), Antonio Vazquez (antoniov).

Yes, the same with Layer opacity. It looks any GPLayer animated paremeter is not working in render.

@Sergey Sharybin (sergey) I know this is related to depsgraph, so I assign to you. Feel free to back to me if you think is something missing in GP modules.

Antonio Vazquez (antoniov) renamed this task from Grease Pencil Stroke Thickness keyframing not being used in rendered animation to GPencil: Any keyframed GPLayer property is not updated when render animation..Nov 26 2019, 11:11 AM
Antonio Vazquez (antoniov) updated the task description. (Show Details)
Sergey Sharybin (sergey) reassigned this task from Sergey Sharybin (sergey) to Antonio Vazquez (antoniov).Nov 26 2019, 11:55 AM

This isn't a dependency graph issue. The actual issue roots to a design violation in the grease pencil drawing code where original bGPdata datablock is forced to be used.

You can escape with such violation in the current viewport because it always considered active (where user performs modifications) and hence animated properties to original datablock.

But you can not escape with this in the final render since that one is supposed to be totally decoupled from original data and from data used by viewport. There is no copy of animation to the original datablock happening there.
This is also what is the planned playback-preview-window will rely on.

Please find a proper solution to whatever problem which was solved by forcing the original datablock in the drawing code.

Antonio Vazquez (antoniov) added a comment.Nov 26 2019, 12:03 PM

Thanks @Sergey Sharybin (sergey), I will take a look.

Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Nov 26 2019, 1:11 PM

Hi @Antonio Vazquez (antoniov) for the records. Recently we are trying to not assign bugs to developers, but to fully triage them and then tag it to a module. To poke a developer (add they as subscribers) is still fine, since there is always some valuable input we can all share.

You can read more about that here: https://wiki.blender.org/wiki/Process/A_Bugs_Life

And yes, most depsgraph bugs are actually bugs elsewhere. But this one is harder to grasp (thank you @Sergey Sharybin (sergey) for your patience ;) )

Antonio Vazquez (antoniov) changed the task status from Unknown Status to Resolved by committing rB9ecc30250aae: Fix T71909: Any keyframed GPLayer property is not updated when render animation.Nov 26 2019, 2:05 PM
Antonio Vazquez (antoniov) added a commit: rB9ecc30250aae: Fix T71909: Any keyframed GPLayer property is not updated when render animation.