Page MenuHome
Create Task
Maniphest T72440

Crash when drag & drop Color in the Image Editor
Closed, ResolvedPublicBUG
Actions

Description

System Information
Windows 10 64 Bits.
Graphics card GeForce GTX 1080 Ti.

Blender Version
Broken: version: 2.82.5 hash:38ad1c4d339d
Worked: 2.81

Short description of error
Color Drop on the image leads to a crash.
Exact steps for others to reproduce the error

  • Create a new Image in the Editor.
  • Drag & Drop Color from the Color picker onto the Canvas like in the image below.

Revisions and Commits

rB Blender
rBbbc97fc533d0 Fix T72440: Dragging & dropping color in the Image Editor crashes

Related Objects

Event Timeline

CobraA (CobraA) created this task.Dec 14 2019, 6:20 AM
William Reynish (billreynish) lowered the priority of this task from 90 to 80.Dec 14 2019, 10:32 AM
William Reynish (billreynish) added a subscriber: William Reynish (billreynish).

I cannot reproduce the issue here. Dropping the color appears to work normally.

Stanislav Blinov (radcapricorn) added a subscriber: Stanislav Blinov (radcapricorn).Dec 15 2019, 5:26 PM

I'm able to reproduce the crash with current master. In a debug build, assertion is triggered:

BLI_assert failed: source/blender/blenkernel/intern/undo_system.c:457, BKE_undosys_step_push_init_with_type(), at 'ustack->step_init == ((void *)0)'
Philipp Oeser (lichtwerk) lowered the priority of this task from 80 to 50.Dec 16 2019, 9:41 AM
Philipp Oeser (lichtwerk) added a project: Sculpt, Paint & Texture.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Can confirm, checking...

Philipp Oeser (lichtwerk) raised the priority of this task from 50 to High.Dec 16 2019, 10:54 AM

Looks like this is also caused by rBc30d6571bb47: Add support for tiled images and the UDIM naming scheme

paint_2d_bucket_fill is called with NULL ImagePaintState from ED_imapaint_bucket_fill...

1  paint_2d_transform_mouse  paint_image_2d.c  1565 0x3a099ad 
2  paint_2d_bucket_fill      paint_image_2d.c  1904 0x3a0aae0 
3  ED_imapaint_bucket_fill   paint_image.c     1315 0x3a03ef1 
4  drop_color_invoke         interface_ops.c   1754 0x3b67ae6 
5  wm_operator_invoke        wm_event_system.c 1441 0x2ffbd68 
6  wm_operator_call_internal wm_event_system.c 1688 0x2ffc66b 
7  wm_handlers_do_intern     wm_event_system.c 2773 0x2fff287 
8  wm_handlers_do            wm_event_system.c 2993 0x2fffdb1 
9  wm_event_do_handlers      wm_event_system.c 3480 0x3001405 
10 WM_main                   wm.c              417  0x2ff50c9 
11 main                      creator.c         496  0x2d22f56

Note there is another assert lurking around [which has been there for quite some time though and is more or less unrelated], namely:

BLI_assert failed: /blender/source/blender/blenkernel/intern/undo_system.c:457, BKE_undosys_step_push_init_with_type(), at 'ustack->step_init == ((void *)0)'

ustack->step_init is not NULL (already has Drop Color, wants to do for ED_imapaint_bucket_fill as well, so seems like two undo pushes where only one is allowed?)

1  raise                                                       0x7ffff1ae4e35 
2  abort                                                       0x7ffff1acf895 
3  BKE_undosys_step_push_init_with_type undo_system.c     457  0x3f9fdeb      
4  image_undo_push_begin                image_undo.c      1017 0x3e95f0f      
5  ED_image_undo_push_begin             image_undo.c      1026 0x3e95fa9      
6  ED_imapaint_bucket_fill              paint_image.c     1308 0x3b5edcf      
7  drop_color_invoke                    interface_ops.c   1700 0x3d67d3c      
8  wm_operator_invoke                   wm_event_system.c 1441 0x32e9559      
9  wm_operator_call_internal            wm_event_system.c 1688 0x32e9e5c      
10 wm_handlers_do_intern                wm_event_system.c 2773 0x32eca78      
11 wm_handlers_do                       wm_event_system.c 2993 0x32ed5a2      
12 wm_event_do_handlers                 wm_event_system.c 3480 0x32eebf6      
13 WM_main                              wm.c              417  0x32e1ba2      
14 main                                 creator.c         496  0x2d17ef6
Philipp Oeser (lichtwerk) added subscribers: Lukas Stockner (lukasstockner97), Campbell Barton (campbellbarton).Dec 16 2019, 11:03 AM

CC @Lukas Stockner (lukasstockner97) (because of UDIM commit)
CC @Campbell Barton (campbellbarton) (because of double undo push)

Lukas Stockner (lukasstockner97) changed the task status from Unknown Status to Resolved by committing rBbbc97fc533d0: Fix T72440: Dragging & dropping color in the Image Editor crashes.Dec 16 2019, 12:47 PM
Lukas Stockner (lukasstockner97) claimed this task.
Lukas Stockner (lukasstockner97) added a commit: rBbbc97fc533d0: Fix T72440: Dragging & dropping color in the Image Editor crashes.
Philipp Oeser (lichtwerk) mentioned this in T72476: Assert Dragging & dropping color in the Image Editor (double UNDO push?).Dec 16 2019, 1:15 PM