Page MenuHome
Create Task
Maniphest T72647

Sculpt mode crash - Sampling detail size (DYNTOPO) while having dyntopo toggled off crashes blender
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.66

Blender Version
Broken: version: 2.82 (sub 6), branch: master, commit date: 2019-12-21 17:23, hash: rBa0892bb690fe
Worked: (optional)

Short description of error

Its possible to use dyntopo eyedropper to sample detail size even if dyntopo is off
Doing so results in sudden crash

Exact steps for others to reproduce the error
-Go to sculpt mode
-make sure dyntopo is off
-Go to dyntopo and change to "constant detail" to make eyedropper appear
-use the dyntopo eyedropper to sample anywhere on the mesh with dyntopo off
-Crash

Revisions and Commits

rB Blender
D6475rB4f70af34e054 Fix T72647: Check if the PBVH type makes sense for the sampling mode

Related Objects

Event Timeline

Vas (Alumx) created this task.Dec 22 2019, 9:15 PM
ronsn added a subscriber: ronsn.Dec 22 2019, 10:20 PM

Yes, I can confirm that. In Blender 2.81 it is not possible to use the eyedropper when Dyntopo is off.

––––––––––––––––––––––––––––

System Information
Operating system: Linux-5.0.0-37-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GTX 1660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21

Blender Version
Broken: version: 2.82 (sub 6), branch: master, commit date: 2019-12-19 23:46, hash: rB110f1cb1d6ac

Worked in: version: 2.81 (sub 16), branch: master, commit date: 2019-12-04 11:32, hash: rBf1aa4d18d49d

Robert Guetzkow (rjg) added a project: Sculpt, Paint & Texture.Dec 23 2019, 12:09 AM
Robert Guetzkow (rjg) lowered the priority of this task from 90 to High.Dec 23 2019, 12:23 AM
Robert Guetzkow (rjg) added subscribers: Pablo Dobarro (pablodp606), Robert Guetzkow (rjg).
This comment was removed by Robert Guetzkow (rjg).
Robert Guetzkow (rjg) added a comment.Dec 23 2019, 12:48 AM

@Pablo Dobarro (pablodp606) It seems this issue was introduced in rB47645a8db6223ba31b8128db7502f27876a2586b and caused by a change of the poll function in SCULPT_OT_sample_detail_size. Previously the picker was properly disabled.

BLI_ghashIterator_init(GHashIterator * ghi, GHash * gh) Line 1083	C
BLI_gsetIterator_init(GSetIterator * gsi, GSet * gs) Line 246	C
BKE_pbvh_bmesh_node_raycast_detail(PBVHNode * node, const float * ray_start, IsectRayPrecalc * isect_precalc, float * depth, float * r_edge_length) Line 1585	C
sculpt_raycast_detail_cb(PBVHNode * node, void * data_v, float * tmin) Line 6881	C
traverse_tree(node_tree * tree, void(*)(PBVHNode *, void *, float *) hcb, void * hit_data, float * tmin) Line 912	C
BKE_pbvh_search_callback_occluded(PBVH * bvh, bool(*)(PBVHNode *, void *) scb, void * search_data, void(*)(PBVHNode *, void *, float *) hcb, void * hit_data) Line 972	C
BKE_pbvh_raycast(PBVH * bvh, void(*)(PBVHNode *, void *, float *) cb, void * data, const float * ray_start, const float * ray_normal, bool original) Line 1781	C
sample_detail_dyntopo(bContext * C, ViewContext * vc, ARegion * ar, int mx, int my) Line 8533	C
sample_detail(bContext * C, int mx, int my, int mode) Line 8563	C
sculpt_sample_detail_size_modal(bContext * C, wmOperator * op, const wmEvent * event) Line 8601	C
wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties) Line 2192	C
wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2960	C
wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3008	C
wm_event_do_handlers(bContext * C) Line 3387	C
WM_main(bContext * C) Line 420	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 520	C
Pablo Dobarro (pablodp606) added a revision: D6475: Fix T72647: Check if the PBVH type makes sense for the sampling mode.Dec 24 2019, 12:30 AM
Pablo Dobarro (pablodp606) claimed this task.Dec 24 2019, 3:56 PM
Pablo Dobarro (pablodp606) closed this task as Resolved by committing rB4f70af34e054: Fix T72647: Check if the PBVH type makes sense for the sampling mode.Jan 7 2020, 5:05 PM
Pablo Dobarro (pablodp606) added a commit: rB4f70af34e054: Fix T72647: Check if the PBVH type makes sense for the sampling mode.