Page MenuHome
Create Task
Maniphest T73171

Delaunay Triangulation not robust enough
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: linux, MacOs
Graphics card: n/a

Blender Version
Broken: 2.81
Worked: (optional)

As reported in this devtalk thread: https://devtalk.blender.org/t/delaunay-2d-cdt-robustness/10968
some uses of the new library routine BLI_delaunay_cdt_calc cause crashes.

Exact steps for others to reproduce the error
The thread has 5 scripts to run, each of which causes a crash.
Two of the bigger ones I have turned into a file that the delaunay unit test program knows how to read:

CIRCcdtinput.txt907 KBDownload

CIRC2cdtinput.txt12 KBDownload

The rest are more easily turned directly into unit tests.

Related Objects

Event Timeline

Howard Trickey (howardt) created this task.Jan 16 2020, 9:10 PM
Howard Trickey (howardt) claimed this task.Jan 16 2020, 9:13 PM

I have been working on this for a while, and had already submitted one change that fixed the first crash, but the other reports showed that a more fundamental rethinking of the code was likely necessary. I am near a solution, but am putting this bug here so that there will be a record of why the rewrite was needed,

Howard Trickey (howardt) changed the task status from Needs Triage to Confirmed.Jan 16 2020, 9:13 PM
Bastien Montagne (mont29) added a project: Modeling.Jan 20 2020, 10:41 AM
Bastien Montagne (mont29) changed the subtype of this task from "Report" to "Bug".
Howard Trickey (howardt) closed this task as Resolved.Jan 28 2020, 5:12 PM

This was fixed with commit rB2867c35d4e72