Page MenuHome

Seaching for operator crashes Blender
Closed, ResolvedPublicBUG

Description

System Information
Operating system: Linux-5.3.0-40-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: Quadro GP100/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.59

Blender Version
Broken: version: 2.83 (sub 8), branch: master, commit date: 2020-03-11 09:14, hash: rBe1b70e9f9c8c

Short description of error
When in Edit Mode an bringing up the operator search, Blender will crash if you type in S and then O.
I was specifically searching for "Solidify" but I don't know what is causing this crash.

Event Timeline

Hans Goudey (HooglyBoogly) changed the task status from Needs Triage to Confirmed.Mar 11 2020, 6:48 PM

Looks like it's caused by the poll of the palette sort operator.

/home/hans/Documents/Blender-Git/blender/source/blender/editors/sculpt_paint/paint_ops.c:383

BKE_paint_get_active_from_context(C); fails and returns null but it's still used later on.

Recent changes here by @Antonio Vazquez (antoniov) from the grease pencil refactor.

This should fix it but it's probably better to do this and also get at the root cause:

diff --git a/source/blender/editors/sculpt_paint/paint_ops.c b/source/blender/editors/sculpt_paint/paint_ops.c
index 6fe1ba0b817..317535738b0 100644
--- a/source/blender/editors/sculpt_paint/paint_ops.c
+++ b/source/blender/editors/sculpt_paint/paint_ops.c
@@ -380,6 +380,10 @@ static void PALETTE_OT_extract_from_image(wmOperatorType *ot)
 static bool palette_sort_poll(bContext *C)
 {
   Paint *paint = BKE_paint_get_active_from_context(C);
+  if (!paint) {
+    return false;
+  }
+
   Palette *palette = paint->palette;
   if (palette) {
     return true;
Philipp Oeser (lichtwerk) triaged this task as High priority.Mar 11 2020, 6:50 PM
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".

Can confirm, checking...