Page MenuHome
Create Task
Maniphest T74690

Rendering workspace: Slot, View Layer & Combined drop downs, displaying label before data.
Closed, ArchivedPublic
Actions

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1660/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.59

Blender Version
Broken: version: 2.83 (sub 8), branch: master, commit date: 2020-03-12 16:33, hash: rB38ba02285846

Less of a Bug, more of a task I think.

  1. Render Default Cube.
  2. Go to Rendering workspace.
  3. Select either the Slot1, View Layer or Combined drop downs.

You should get this:

If you flip the header to the bottom, you get this:

I have looked around and the issue lies in Blender\Editors\space_image\image_buttons.c

  1. I would like to take a look at resolving this &
  2. The Slot drop down list, displays information in the order of Slot 8 -> Slot 1. I wonder if it would be better if the order was Slot 1 -> Slot 8 (Personal Preference)?

If so I would like to tackle this as well.

Event Timeline

Adrian Newton (TFS) created this task.Mar 12 2020, 6:46 PM
Adrian Newton (TFS) added projects: User Interface, Render Pipeline.Mar 12 2020, 7:42 PM
Adrian Newton (TFS) added a comment.Mar 13 2020, 2:05 PM

The following Diff resolves the issue of the Labels being in the wrong place, Point 1. above.

Slot-View Layer-Combined_Label Fix.diff3 KBDownload

If you wish me to submit another patch to change the Slot display order from it's current Slot 8 -> Slot 1 order, to Slot 1 -> Slot 8, then let me know,

Richard Antalik (ISS) closed this task as Archived.Mar 13 2020, 3:06 PM
Richard Antalik (ISS) claimed this task.
Richard Antalik (ISS) added subscribers: William Reynish (billreynish), Richard Antalik (ISS).

@TFM please use https://developer.blender.org/differential/diff/create/ to post patches.
I would recommend to look at https://wiki.blender.org/wiki/Tools/CodeReview as general guide
You can tag perhaps @William Reynish (billreynish) as a reviewer. Or tag User Interface project in general

In general I recommend to get in touch with developer before working on new features, so your work is not for nothing.

Unless this is agreed to be worked on I will close this report, because it is not a bug.

Adrian Newton (TFS) added a comment.Mar 13 2020, 3:19 PM

Thanks. I shall submit using Diff mechanism as you suggest.