Page MenuHome
Create Task
Maniphest T74790

Artifacts in solid view
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Linux-5.4.24-1-MANJARO-x86_64-with-glibc2.29 64 Bits
Graphics card: AMD VERDE (DRM 2.50.0, 5.4.24-1-MANJARO, LLVM 9.0.1) X.Org 4.5 (Core Profile) Mesa 19.3.5

Blender Version
Broken: version: 2.83 (sub 9), branch: master (modified), commit date: 2020-03-15 18:43, hash: rB22925d0dd31e (Master is modified because I had to revert commit 56d6666689f7 because of https://developer.blender.org/T74024 it also show artifacts without the revert), blender-2.83-a210b8297f5a-linux64
Worked: 2.82 official, version: 2.82 (sub 6), branch: master, commit date: 2020-01-14 15:55, hash: rBba5bbf14f92b, 2.83 56d6666689f7

Short description of error
There are artifacts on the geometry in solid shading (can't see them in the other modes). On a different system with intel skylake with integrated graphics, the artifacts are not visible.

Exact steps for others to reproduce the error
Open blender, rotate camera around default cube until you see the artifacts (in the default view position it is not very visible. It helps to move closer to the cube and to look at the brighter areas)

Related Objects

Event Timeline

Georg K (georg) created this task.Mar 15 2020, 9:12 PM
Georg K (georg) updated the task description. (Show Details)Mar 16 2020, 12:41 AM
Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).Mar 16 2020, 7:32 AM

As mentioned in the ticket this could be related to T74024: Faces missing, weird faces added
Biggest challenge of this ticket is that we cannot reproduce this with the hardware we have. But as it has worked for some releases.
It would help us to perform a git bisect or check with renderdoc on this issue; would that be something you could help us with?

Georg K (georg) mentioned this in T74791: Crash trying to open Spring Splash scene.Mar 16 2020, 2:40 PM

Found it! This commit also caused the crash opening the Spring splash scene https://developer.blender.org/T74791

c476c36e400883d929a7149def8dcb6ad6157a86 is the first bad commit
commit c476c36e400883d929a7149def8dcb6ad6157a86
Author: Clément Foucault <foucault.clem@gmail.com>
Date: Wed Mar 11 17:07:43 2020 +0100

Workbench Simplification Refactor

This patch is (almost) a complete rewrite of workbench engine.
The features remain unchanged but the code quality is greatly improved.
Hair shading is brighter but also more correct.

This also introduce the concept of `DRWShaderLibrary` to make a simple
include system inside the GLSL files.

Differential Revision: https://developer.blender.org/D7060
Jeroen Bakker (jbakker) added a subscriber: Clément Foucault (fclem).Mar 16 2020, 4:08 PM

@Georg K (georg) Thanks, That is a big patch. @Clément Foucault (fclem) do you have an idea what could corrupt this on old AMD cards?

Asher (ThatAsherGuy) added a subscriber: Asher (ThatAsherGuy).Mar 16 2020, 6:39 PM

I've noticed similar artifacts in wireframe view on my system (Win 10, 2600X, RTX 2060 442.59), so this might not be hardware/driver specific.

Georg K (georg) added a comment.Mar 16 2020, 7:49 PM

No artifacts in wireframe view here.

Clément Foucault (fclem) added a comment.Mar 17 2020, 1:36 PM

@Georg K (georg) we need a bit more testing: does that happen with all shading mode? color mode? with outline enabled? with cavity enabled? etc...

Is there any configuration (which is not Xray or wireframe) that works?

Georg K (georg) added a comment.EditedMar 17 2020, 3:39 PM

There is a configuration that works: Specular Lighting: off removes the artifacts. There is also a slight improvement by setting Antialiasing >= 5Samples as long as there is no interaction.
Also, setting Specular Lighting to "off" and deactivating "Load UI" in the file view allows to load the Spring splash scene https://developer.blender.org/T74791 without crashing.

tested cases in detail:
Viewport Antialiasing off/Single Pass Antialiasing: artifacts in both cases
Viewport Antialiasing 5Samples - 32Samples : artifacts in all cases,
But: with higher sample count, artifacts vanish if the view is not moved (looks like blurring). Once the camera is moved, they become visible again and flicker as long as the viewport is interacted with. The pattern also changes if a different tool is selected or while the cursor is moved over the navigation gizmo.

Overlay Smooth Wires on/off: artifacts in both cases
Edit Mode Smooth Wires on/off: artifacts in both cases (does not seem to have any effect on wire smoothness in edit mode in contrast to Overlay Smooth Wires. Edit mode wires always seem smooth)

Shading mode?
wire : -
solid : artifacts
material: -
rendered: -

Solid shading - Viewport shading: Color=Material/Object/Vertex/Single/Random/Texture: artifacts in all cases

Background Theme/World/Viewport: artifacts in all cases

Options:
Shadow on/off: artifacts in both cases
Cavity on/off: artifacts in both cases
Outline on/off: artifacts in both cases
Specular Lighting on: artifacts
Specular Lighting off: no artifacts

Richard Antalik (ISS) added a project: EEVEE & Viewport.Mar 23 2020, 1:02 PM
Clément Foucault (fclem) changed the subtype of this task from "Report" to "Bug".Mar 23 2020, 6:18 PM
Germano Cavalcante (mano-wii) changed the task status from Needs Triage to Confirmed.Mar 24 2020, 2:36 PM
Germano Cavalcante (mano-wii) mentioned this in T75063: Wireframe Drawing Errors.Mar 25 2020, 7:04 PM
Georg K (georg) added a comment.Apr 15 2020, 6:44 PM

Retested rB22925d0dd31e after mesa upgrade from 19.3.5-1 to 20.0.4-1 and the artifacts are gone.

Georg K (georg) closed this task as Resolved.Apr 15 2020, 6:44 PM