Page MenuHome
Create Task
Maniphest T75388

Adaptive sampling artifacts
Closed, ResolvedPublicBUG
Actions

Description

Just rebuilt Blender from scratch this morning. Upon rendering with adaptive sampling (both CPU and GPU), there is bad artifacting that resembles salt and pepper noise. This does not occur with non-adaptive rendering (CPU and GPU)

Steps to reproduce:

Open new file, select 'Cycles' as the render engine and enable Adaptive sampling, then render.

Git Revision: e455536943a862334a765fdef7edfd16b2e9b5b1

Revisions and Commits

rC Cycles
rC0c170f7daebf Revert "Fix T74572: adaptive sampling not scaling render passes correctly"
rB Blender
rBe05552f7c4ac Revert "Fix T74572: adaptive sampling not scaling render passes correctly"

Related Objects

Event Timeline

Jonathan Dent (jdent02) created this task.Apr 4 2020, 8:50 PM

This is with the adaptive threshold set to .001

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Apr 5 2020, 1:25 PM
Philipp Oeser (lichtwerk) triaged this task as High priority.
Philipp Oeser (lichtwerk) added a project: Render & Cycles.
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".
Philipp Oeser (lichtwerk) added subscribers: Brecht Van Lommel (brecht), Philipp Oeser (lichtwerk).

Caused by rB82a8da0ec38a: Fix T74572: adaptive sampling not scaling render passes correctly.

CC @Brecht Van Lommel (brecht)

Philipp Oeser (lichtwerk) mentioned this in T75396: Cycles – Rendering with "Adaptive Sampling" Produces Artifacts.Apr 5 2020, 1:26 PM
Philipp Oeser (lichtwerk) merged a task: T75396: Cycles – Rendering with "Adaptive Sampling" Produces Artifacts.
Philipp Oeser (lichtwerk) added subscribers: ronsn, Evan Wilson (EAW).
Philipp Oeser (lichtwerk) mentioned this in T75411: Adaptive Sampeling with Square Samples Artifacts.Apr 5 2020, 1:42 PM
Philipp Oeser (lichtwerk) merged a task: T75411: Adaptive Sampeling with Square Samples Artifacts.
Philipp Oeser (lichtwerk) added a subscriber: Julian Mohr (Jules).
Philipp Oeser (lichtwerk) added a project: BF Blender.Apr 5 2020, 1:50 PM
Jason Clarke (jtheninja) added a subscriber: Jason Clarke (jtheninja).Apr 5 2020, 5:51 PM
Alaska (Alaska) added a subscriber: Alaska (Alaska).EditedApr 6 2020, 7:23 AM

Just thought I'd add to this. Using build 505a19ed75b2 on Linux I experience this issue. However, I've noticed it affect's many other passes than just the just the beauty pass. Here's a list:

Affected Passes:
Combined (standard render)
Normal
UV
AO
Emission
Environment
Mist Pass
Diffuse Colour
Glossy Colour
Transmission Colour
Volume Direct
Volume Indirect
Debug Sample Count

Passes with no issues as far as I can tell:
Depth
Vector
Shadow
Diffuse Direct
Diffuse Indirect
Glossy Direct
Glossy Indirect
Transmission Indirect
Noisy Image
Denoising Normal
Denoising Albedo
Cryptomatte

Luckily for us, this means that we can use the "Noisy Image" pass in a compositor if we still want our image with adaptive sampling until a patch is out.

These are the passes I'm unsure about:
Object and Material ID
Transmission Direct
Denoising Depth
Denosing Clean
Render time

Brecht Van Lommel (brecht) closed this task as Resolved by committing rBe05552f7c4ac: Revert "Fix T74572: adaptive sampling not scaling render passes correctly".Apr 6 2020, 11:24 PM
Brecht Van Lommel (brecht) claimed this task.
Brecht Van Lommel (brecht) added a commit: rBe05552f7c4ac: Revert "Fix T74572: adaptive sampling not scaling render passes correctly".
Brecht Van Lommel (brecht) added a commit: rC0c170f7daebf: Revert "Fix T74572: adaptive sampling not scaling render passes correctly".Jun 2 2020, 7:46 AM