Page MenuHome
Create Task
Maniphest T75457

Sculpt Mask brush toggle hotkey is broken
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Win 10

Blender Version
Broken: blender-2.83-7c0e28594840-windows64
Worked: blender-2.80-windows64

Short description of error
The sculpting mask brush hotkey (M) used to work as a toggle on previous versions of blender, which means, if you press "M" it would switch to the mask brush, and once you press "M" again it would switch back to the previous sculpting brush you were using. But that's no longer the case, even though the Toggle property checkbox is enabled in the keymap...

Exact steps for others to reproduce the error
Launch Blender
Go to File/New/Sculpting
Press "M" and it will switch to the mask brush
Press "M" again and nothing will happen. (it should toggle back to the draw brush)

Revisions and Commits

rB Blender
D7792rBd33c27d68bb3 Fix T75457: Toggle brushes using same hotkey twice is broken

Related Objects

Event Timeline

TheRedWaxPolice (TheRedWaxPolice) created this task.Apr 6 2020, 9:41 PM
Ankit Meel (ankitm) added a subscriber: Ankit Meel (ankitm).Apr 7 2020, 7:57 AM

The shortcut of draw brush is X though

TheRedWaxPolice (TheRedWaxPolice) added a comment.EditedApr 7 2020, 2:41 PM
In T75457#905058, @Ankit Meel (ankitm) wrote:

The shortcut of draw brush is X though

Of course. But what it has to do with this bug report?
Have you tried to replicate the bug?

Nelson (NAS) added a subscriber: Nelson (NAS).Apr 7 2020, 3:52 PM

I can confirm this regression.

Richard Antalik (ISS) changed the task status from Needs Triage to Confirmed.Apr 7 2020, 3:58 PM
Richard Antalik (ISS) updated the task description. (Show Details)
Richard Antalik (ISS) added a project: Sculpt, Paint & Texture.
Philipp Oeser (lichtwerk) added a project: User Interface.May 18 2020, 5:56 PM
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".
Philipp Oeser (lichtwerk) added subscribers: Campbell Barton (campbellbarton), Philipp Oeser (lichtwerk).

Caused by rB47da01a4db1d: Fix T70211: Brush keybindings failed with non-brush tool active, so I think this is indeed a bug...

CC @Campbell Barton (campbellbarton)

Philipp Oeser (lichtwerk) claimed this task.May 18 2020, 6:31 PM

Think I got it, Diff incoming shortly...

Philipp Oeser (lichtwerk) added a comment.May 19 2020, 2:56 PM

This is because we correctly switch the brush back to Brush->toggle_brush, but immediately after set the tool to the Tool for which the hotkey is assigned.
https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/sculpt_paint/paint_ops.c$737

First I thought it would be easy to get the tool from the toggle_brush, but needs a bit more investigation...

Philipp Oeser (lichtwerk) added a revision: D7792: Fix T75457: Toggle brushes using same hotkey twice is broken.May 19 2020, 5:26 PM
Philipp Oeser (lichtwerk) closed this task as Resolved by committing rBd33c27d68bb3: Fix T75457: Toggle brushes using same hotkey twice is broken.May 20 2020, 3:17 PM
Philipp Oeser (lichtwerk) added a commit: rBd33c27d68bb3: Fix T75457: Toggle brushes using same hotkey twice is broken.