Page MenuHome
Create Task
Maniphest T77130

Visually broken/stepped wireframe in object mode (regression)
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87

Blender Version
Broken: version:
2.83 (sub 17), branch: master, commit date: 2020-05-27 16:03, hash: rB79e529c5ec16
2.90 (sub 4), branch: master, commit date: 2020-05-27 18:04, hash: rBd7282537f016
Worked:
blender-2.83-e8dd8c2829f3-windows64

Short description of error
Edit mode looks properly. But object mode have stair on circle mesh

without antialiasing it looks worse

previous builds:

Revisions and Commits

rB Blender
D7873rB1d2b89304ac3 Fix T77130: Visually broken/stepped wireframe in object mode (regression)

Related Objects

Event Timeline

Vyacheslav (hitrpr) created this task.May 28 2020, 4:12 PM
Hans Goudey (HooglyBoogly) added a project: EEVEE & Viewport.May 28 2020, 10:13 PM
Alaska (Alaska) changed the task status from Needs Triage to Confirmed.EditedMay 29 2020, 3:49 AM
Alaska (Alaska) edited projects, added BF Blender (2.83); removed BF Blender.
Alaska (Alaska) added a subscriber: Alaska (Alaska).

Can confirm while testing with these Blender versions:
2.83 rBf772a4b8fa87 (2020-05-26 22:42)
2.83 rB79e529c5ec16 (2020-05-27 16:03)
2.83 rBff1040c6fefc (2020-05-28 11:42)
2.90 rB2deb6c517787 (2020-05-28 18:34)
On Windows 10 with a GTX 1050Ti with driver 445.87.

I will update the task description along with look at recent commits to see if I can pin point the commit that caused the issue. At the moment I haven't figured out how to bi-sect builds.

Alaska (Alaska) updated the task description. (Show Details)May 29 2020, 3:51 AM
Alaska (Alaska) added a comment.May 29 2020, 3:58 AM

rB39aa122a0e6d is most likely the cause. The commit says

HACK: to avoid loosing sub pixel object in selections, we add a bit of randomness to the wire to at least create one fragment that will pass the occlusion query.
TODO(fclem) Limit this workaround to selection. It's not very noticeable but still...
Alaska (Alaska) added a subscriber: Clément Foucault (fclem).EditedMay 29 2020, 3:59 AM

@Clément Foucault (fclem) Are you able to comment on this?
Is the cause actually this commit?
If it is the commit, what's the plan going forward? Temporarily revert the commit or leave it in there and fix it at a later date?

Alaska (Alaska) changed the subtype of this task from "Report" to "Bug".May 29 2020, 4:02 AM
Chingiz Jumagulov (Krayzmond) added a subscriber: Chingiz Jumagulov (Krayzmond).May 29 2020, 4:37 AM
Clément Foucault (fclem) added a comment.May 29 2020, 10:45 AM

I'm going to fix it right away.

Clément Foucault (fclem) triaged this task as Unbreak Now! priority.May 29 2020, 10:46 AM
Alaska (Alaska) added a comment.May 29 2020, 11:00 AM

Thank you @Clément Foucault (fclem) for all the work you do.

Clément Foucault (fclem) closed this task as Resolved by committing rB1d2b89304ac3: Fix T77130: Visually broken/stepped wireframe in object mode (regression).May 29 2020, 12:29 PM
Clément Foucault (fclem) claimed this task.
Clément Foucault (fclem) added a commit: rB1d2b89304ac3: Fix T77130: Visually broken/stepped wireframe in object mode (regression).
Vyacheslav (hitrpr) awarded a token.May 29 2020, 8:09 PM
Paul Kotelevets (1D_Inc) awarded a token.May 29 2020, 8:23 PM
kaiwas (kaiwas) awarded a token.May 29 2020, 8:25 PM