Page MenuHome
Create Task
Maniphest T77719

Pressing undo unwantedly changes the active grease pencil tool
Closed, ArchivedPublic
Actions

Description

System Information
Operating system: Darwin-19.3.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 580 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.5.5

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-06 14:18, hash: rBaed11c673efe

Short description of error
Pressing undo unwantedly changes the active grease pencil tool.

Exact steps for others to reproduce the error

  1. draw a grease pencil stroke.
  2. switch to sculpt>push mode and alter the stroke.
  3. press undo twice.
  4. the active tool is now draw again (expected to remain on sculpt>push).

video showing what happens here: https://www.youtube.com/watch?v=BUH2wHr-3tw

this seems related to https://developer.blender.org/T59544 and https://developer.blender.org/T57750

Related Objects

Event Timeline

Tomasz Kaye (bitbutter) created this task.Jun 10 2020, 12:01 PM
Tomasz Kaye (bitbutter) added a project: Grease Pencil.
Antonio Vazquez (antoniov) added subscribers: Bastien Montagne (mont29), Antonio Vazquez (antoniov).EditedJun 10 2020, 12:30 PM

I'm not sure what you expect, but the Undo is a "walk" in reverse direction of your previous steps, so if your steps are Draw->Change Mode->Sculpt the undo must be Sculpt->Change Mode->Draw

@Bastien Montagne (mont29) What do you think of this?

Tomasz Kaye (bitbutter) added a comment.Jun 10 2020, 12:49 PM

hi Antonio. What i was expecting is that the 'active' tool/mode was independent of the undo stack (and wouldn't be changed when undoing).

This is the way it works with all other drawing/painting apps i remember using (Photoshop, Flash/Animate, Toon Boom Harmony, TVPaint, Clip Studio Paint).

Here's a video demonstrating how it's arranged in photoshop for instance https://youtu.be/yBoxrgZVMj4

Tomasz Kaye (bitbutter) added a comment.EditedJun 10 2020, 1:08 PM

More context: the grease pencil tools do work as i expected (active tool not affected by undoing) when the tools that were used before undoing were all part of the same mode (e.g. drawing and erasing). Looks like active-tool independence from undo stack was adjusted in response to this issue https://developer.blender.org/T57750

But currently when tools from different modes are used, undoing those steps adjusts the active tool and mode. This seems inconsistent.

Spencer Linkous (slinkous) added a subscriber: Spencer Linkous (slinkous).Jun 10 2020, 3:02 PM

I like that that happens, so I'd recommend a setting where you can either enable or disable that in user prefs.

Germano Cavalcante (mano-wii) closed this task as Archived.Jun 11 2020, 2:37 PM
Germano Cavalcante (mano-wii) claimed this task.
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior.
I suggest discussing this elsewhere like devtalk: https://devtalk.blender.org/

Tomasz Kaye (bitbutter) mentioned this in T71759: Sculpt/Vertex/Weight Paint Brush Size Gets Undone After Undoing a Stroke.Jul 30 2020, 8:01 AM