Page MenuHome
Create Task
Maniphest T78370

OIDN Viewport Denoiser start sample behaviour differs depending on number of viewport samples
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Darwin-19.5.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 5500M OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.9.15

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-25 21:53, hash: rB62aa103d485f
Worked: n.a.

Short description of error
When viewport samples is set to 1 and start sample to 1, you immediately get a denoised image. When viewport samples is set to anything larger than 1 and start sample to 1, you get noisy images while the first 2 samples are being rendered, and then the first denoised image appears while the third sample is rendered. Setting the start sample to 0 does directly give a denoised image.

Exact steps for others to reproduce the error
Cycles rendered view, viewport denoising set to OIDN
Viewport samples 1, denoising start sample 1: denoised image appears directly
Viewport samples >1, denoising start sample 1: denoised image appears when the third sample is being rendered
Viewport samples 1, denoising start sample 0: denoised image appears directly

Related Objects

Event Timeline

Wouter Stomp (wouterstomp) created this task.Jun 27 2020, 10:45 PM
YAFU (YAFU) added a subscriber: YAFU (YAFU).Jun 28 2020, 1:31 PM

This that I am going to comment has to do more than anything with the title of the entry, for me not to open a new report because the problems may be related. Here I commented something about it:
https://developer.blender.org/rB669befdfbe487f76c65f54e3da0013d140d56893#270857

The point is that depending on the Viewport Samples and Start Sample settings, denoising in viewport may not run under certain circumstances, not only with OIDN but also with Optix denoiser. I think this could be due to render speed in viewport according to the scene, so people with different hardware could get different behaviors and perhaps not everyone can reproduce the problem in the same way. Anyway it is not clear to me exactly when the problem occurs.
Here is a .blend file:

Bug 2.9-viewport denoising volumetric world vs no volumetric world.blend115 KBDownload

On my machine (i7-3770 CPU), by default scene does not run denoiser in viewport. If in the scene with the same settings you in World tab select Volumetric World instead of World, then rendering in viewport is slower and when it reach Start Sample then denoiser it is executed and work this time.

Richard Antalik (ISS) added a project: Render & Cycles.Jul 1 2020, 2:47 AM
Richard Antalik (ISS) added a subscriber: Richard Antalik (ISS).

I can confirm this, but I am not sure if this is bug or some limitation.

Sebastian Parborg (zeddb) added subscribers: Brecht Van Lommel (brecht), Sebastian Parborg (zeddb).Aug 12 2020, 4:59 PM

@Brecht Van Lommel (brecht) bug or not?

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Needs Information from User.Oct 14 2020, 7:49 PM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Not totally sure if I am reading this report correctly.
Is this the same (or similar) then T79680: Viewport denoiser interrupts on late sample start.?

In that case it should be fixed already with rB58a457da3d89: Fix T79680, T79680: confusing viewport denoise start sample behavior.
Could you guys check if this is still an issue in a fresh build from https://builder.blender.org/download/?

If this is still the case, please confirm it (if you can), does not have to be classified as bug (but confirming helps already).

Wouter Stomp (wouterstomp) added a comment.Oct 15 2020, 12:37 PM

It works as expected now, this bug can be closed, thanks.

Wouter Stomp (wouterstomp) closed this task as Resolved.Oct 15 2020, 12:37 PM