Page MenuHome
Create Task
Maniphest T80819

Zoom To Border operator - zoom factor is too high in the perspective view.
Closed, ResolvedPublicTO DO
Actions

Description

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 770/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.75

Blender Version
Broken: version: 2.83.5, branch: master, commit date: 2020-08-19 06:07, hash: rBc2b144df395f
Worked: (probably never)

Short description of error
Hello.
I wanted to point out the incorrect behavior of the "view3d.zoom_border" operator in the perspective view.
As you can see in the gif below in Perspective view, zoom factor is too high in relation to the drawn frame.
This behavior is especially inconvenient when working in navigation mode with the "Auto Perspective" option turned on.
Thank you
Gif:

Revisions and Commits

rB Blender
ClosedD9341 Improvements to "Zoom to Border"-operator (T80819)
rB77a6b6fb1ac0 Fix T80819: Border zoom is isn't accurate in perspective view

Event Timeline

Nanomanpro created this task.Sep 15 2020, 9:27 PM
Nanomanpro updated the task description. (Show Details)
Campbell Barton (campbellbarton) changed the subtype of this task from "Report" to "To Do".Sep 16 2020, 7:00 AM
Campbell Barton (campbellbarton) added projects: EEVEE & Viewport, Restricted Project.
Campbell Barton (campbellbarton) moved this task from Backlog to Papercuts on the EEVEE & Viewport board.Sep 16 2020, 7:32 AM
Germano Cavalcante (mano-wii) changed the task status from Needs Triage to Confirmed.Sep 16 2020, 11:58 PM
Erik Abrahamsson (erik85) added a subscriber: Erik Abrahamsson (erik85).Oct 24 2020, 7:58 PM

I'm not able to reproduce this. Can you give some more info on how to reproduce it? Or can you check if it's fixed in the latest Blender version?

Yevgeny Makarov (jenkm) added a subscriber: Yevgeny Makarov (jenkm).EditedOct 24 2020, 8:41 PM

T80819.mov10 MBDownload

Erik Abrahamsson (erik85) claimed this task.EditedOct 24 2020, 10:51 PM

Ah, I get what part of the problem is now. It's not taking the viewport focal length into account. The problem gets worse as you increase the focal length of the viewport.
Another problem is that the height of the selection box is not very important in the calculations either which means any box with a lower x/y ratio than the view will get cut more.
I made a patch that kind if works a bit better but I will continue investigating.

Erik Abrahamsson (erik85) added a revision: D9341: Improvements to "Zoom to Border"-operator (T80819).Oct 25 2020, 2:08 AM
Campbell Barton (campbellbarton) closed this task as Resolved by committing rB77a6b6fb1ac0: Fix T80819: Border zoom is isn't accurate in perspective view.Oct 27 2020, 4:13 AM
Campbell Barton (campbellbarton) added a commit: rB77a6b6fb1ac0: Fix T80819: Border zoom is isn't accurate in perspective view.