Page MenuHome
Create Task
Maniphest T81925

Splash Screen can not be closed
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: Quadro RTX 4000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 452.06

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-10-20 03:39, hash: rBefc2edc47f7a
Worked: 2.90

Short description of error
Very similar behavior to T58692 - Basically I can not close the initial splash screen, the click on the button does absolutely nothing:

The reason could again be that we use the environment variables BLENDER_USER_CONFIG, BLENDER_USER_DATAFILES and BLENDER_USER_SCRIPTS to share our Blender settings within the company. However, BLENDER_USER_CONFIG is unique for every user we have, whereas the other two are identical for each user.

Exact steps for others to reproduce the error
Set the aforementioned variables to a network drive location (on Windows) and start Blender. Should see the behavior described in the GIF.

Revisions and Commits

rB Blender
ClosedD9306 Fix incorrectly skipped string copy in test_env_path
rBe1eaf9e2b4ef Fix T81925: incorrectly skipped string copy in test_env_path
rBef5d6e9c457a Fix T81925: incorrectly skipped string copy in test_env_path

Related Objects

Event Timeline

Rainer Trummer (aliasguru) created this task.Oct 21 2020, 5:06 PM
Robert Guetzkow (rjg) changed the task status from Needs Triage to Needs Information from User.Oct 21 2020, 6:26 PM
Robert Guetzkow (rjg) added a subscriber: Robert Guetzkow (rjg).

In the other ticket (T58692) you state that the issue was recently introduced to 2.91. Do you know of a previous version of 2.91 that didn't have this issue? That could help to narrow down which commit caused this change in behavior. Does this happen with any network drive or only under specific circumstances, e.g. if there is a large latency or the network drive fails to respond?

Harley Acheson (harley) added a subscriber: Harley Acheson (harley).Oct 21 2020, 7:03 PM

Is this really that the splash won't close or about the initial setup not running?

The gif shows clicking on the "Next" button and within the empty dark grey area. But the grey area should do nothing. Closing of the dialog should occur if you click on the splash image itself or anywhere outside the dialog. Does it close if you do either of those things?

Brecht Van Lommel (brecht) triaged this task as High priority.EditedOct 21 2020, 7:45 PM
Brecht Van Lommel (brecht) edited projects, added BF Blender (2.91); removed BF Blender.
Brecht Van Lommel (brecht) added subscribers: Campbell Barton (campbellbarton), Brecht Van Lommel (brecht).

@Campbell Barton (campbellbarton), this is caused by rB6f3a9031f7b9: Cleanup: BKE_appdir left paths set even when not found.

The underlying issue can be reproduced like this, there's an invalid string coming from the Python API:

$ BLENDER_USER_CONFIG=/tmp ../build_linux_lite/bin/blender -b --python-expr "import bpy; print('user config: ' + bpy.utils.user_resource('CONFIG'))"
Blender 2.91.0 Alpha
found bundled python: /home/brecht/dev/build_linux_lite/bin/2.91/python
user config: ���
Brecht Van Lommel (brecht) changed the task status from Needs Information from User to Confirmed.Oct 21 2020, 7:45 PM
Robert Guetzkow (rjg) added a comment.EditedOct 21 2020, 9:18 PM

The bug is caused by the change to test_env_path. The commit introduced the following part:

+  if (check_is_dir == false) {
+#ifdef PATH_DEBUG
+    printf("\t%s using without test: %s\n", __func__, targetpath);
+#endif
+    return true;
+  }
+
  if (BLI_is_dir(env)) {
    BLI_strncpy(path, env, FILE_MAX);
#ifdef PATH_DEBUG
    printf("\t%s env %s found: %s\n", __func__, envvar, env);
#endif
    return true;
  }

This change causes the function to return before env is copied to path. If the intention was to skip the BLI_is_dir(env) check in the function, then it should have still called the BLI_strncpy(path, env, FILE_MAX);.

Call stack of the old code:

BKE_appdir_folder_id_user_notest(const int folder_id, const char *subfolder)
get_path_environment_notest(path, sizeof(path), subfolder, "BLENDER_USER_CONFIG")
test_env_path(user_path, envvar)

The call to test_env_path copies the path of the environment variable into user_path.

Call stack of the new code:

BKE_appdir_folder_id_user_notest(const int folder_id, const char *subfolder)
get_path_environment_ex(path, sizeof(path), subfolder, "BLENDER_USER_CONFIG", check_is_dir)
test_env_path(user_path, envvar, check_is_dir)

In this call check_is_dir is false and test_env_path returns early, failing to set user_path.

Robert Guetzkow (rjg) claimed this task.Oct 21 2020, 9:53 PM
Ankit Meel (ankitm) changed the subtype of this task from "Report" to "Bug".Oct 21 2020, 9:55 PM
Ankit Meel (ankitm) added a project: User Interface.
Hans Goudey (HooglyBoogly) moved this task from Backlog to Bugs on the User Interface board.Oct 21 2020, 10:15 PM
Robert Guetzkow (rjg) added a revision: D9306: Fix incorrectly skipped string copy in test_env_path.Oct 21 2020, 10:30 PM
Campbell Barton (campbellbarton) closed this task as Resolved by committing rBef5d6e9c457a: Fix T81925: incorrectly skipped string copy in test_env_path.Oct 22 2020, 12:53 AM
Campbell Barton (campbellbarton) added a commit: rBef5d6e9c457a: Fix T81925: incorrectly skipped string copy in test_env_path.
Campbell Barton (campbellbarton) added a commit: rBe1eaf9e2b4ef: Fix T81925: incorrectly skipped string copy in test_env_path.Oct 22 2020, 12:56 AM