Page MenuHome

Ratio displayed with a % sign in the Decimate Keyframes Adjust Last Operation panel.
Closed, ResolvedPublicBUG

Description

Blender Version
Broken: Since it's introduction in 2.82 to current master.
The issue even appears in the release notes demo video.


Short description of error
Small bug, more of an inconsistency. The percentage goes from 0 to 1, which is decimal and not percentage, yet shows a % symbol.

This isn't how percentages work. Half way should be 50%, not 0.500%; 100%, not 1.000%. Of course the percentage symbol could just be removed and it'd be correct to have 0.5 and 1 as half and full.

This specific case is in decimating keyframes 'Remove' slider in the f-curve modifier, though maybe it happens everywhere else and I only just noticed.

Exact steps for others to reproduce the error
Open the following file:


In the graph editor, open the menu Key->Decimate (Ratio)
Confirm the operation with left mouse click.
Look at the Adjust Last Operation Panel.

Event Timeline

Evan Wilson (EAW) changed the task status from Needs Triage to Confirmed.EditedOct 25 2020, 8:22 PM

Confirmed in 2.82a, 2.83, current master & 2.90

It is correctly displayed in the header.
decimate_draw_status_header

Evan Wilson (EAW) renamed this task from 0.5% is not half, should be 50% to Ratio displayed with a % sign in the Decimate Keyframes Adjust Last Operation panel..Oct 25 2020, 9:01 PM
Evan Wilson (EAW) updated the task description. (Show Details)

@Sebastian Parborg (zeddb) Tagging you here since you implemented this feature.

"remove_ratio" should be a RNA_def_float to remove the % sign, or keep it as a RNA_def_float_percentage and change the max value to 100 and change the execution code I guess.

RNA_def_float_percentage is used wrongly in two other places in the code: pose slide and gpencil interpolate.

Thanks for pointing that out @Erik Abrahamsson (erik85). I made a patch to improve the situation: D9344

Hans Goudey (HooglyBoogly) triaged this task as Low priority.Oct 26 2020, 12:15 AM
Hans Goudey (HooglyBoogly) changed the subtype of this task from "Report" to "Bug".