Page MenuHome
Create Task
Maniphest T82397

Some mouse clicks in the outliner don't register
Closed, ArchivedPublic
Actions

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.23

Blender Version
Broken: version: 2.91.0 Alpha, branch: master, commit date: 2020-10-15 08:00, hash: rBf1aa55b6e9cd

Short description of error
Some mouse clicks in the outliner don't register.

Exact steps for others to reproduce the error
Create a new blend file. In the outliner repeatedly click the twirl-down triangle of the default cube. Some clicks do not register (fail to toggle the twirl-down).

Screen recording demonstrating the problem.
https://youtu.be/40fKYVfFdEA

(possibly related to this report https://developer.blender.org/T82322)

Related Objects

Event Timeline

Tomasz Kaye (bitbutter) created this task.Nov 4 2020, 11:05 AM
Tomasz Kaye (bitbutter) updated the task description. (Show Details)
Robert Guetzkow (rjg) changed the task status from Needs Triage to Needs Information from User.Nov 4 2020, 11:09 AM
Robert Guetzkow (rjg) added a project: User Interface.
Robert Guetzkow (rjg) added a subscriber: Robert Guetzkow (rjg).

Your referenced report is about input from a Wacom tablet. Is this method of input used here as well, or are you using a mouse?

Tomasz Kaye (bitbutter) added a comment.Nov 4 2020, 1:21 PM

here i'm using a mouse.

Yevgeny Makarov (jenkm) added a subscriber: Yevgeny Makarov (jenkm).Nov 4 2020, 1:59 PM

If you set "Double Click Speed" to 1 - there is no this issue. So it's about double-clicking. Try clicking fast enough (about the speed of a double click).

Philipp Oeser (lichtwerk) closed this task as Archived.Nov 4 2020, 3:53 PM
Philipp Oeser (lichtwerk) claimed this task.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

As @Yevgeny Makarov (jenkm) said: this is consumed as a doubleclick, but this is not a bug.

Yevgeny Makarov (jenkm) added a comment.EditedNov 4 2020, 3:57 PM

@Philipp Oeser (lichtwerk) But in the Properties editor, collapsing panels works without this problem.

What's the difference?

Tomasz Kaye (bitbutter) added a comment.EditedNov 4 2020, 4:03 PM

seems it shouldn't be consumed as a double click if the underlying UI element (e.g. a twirl-down toggle) doesn't respond to double clicks. At least this is how all the other UIs i've used work.

Philipp Oeser (lichtwerk) added a comment.Nov 4 2020, 4:16 PM
In T82397#1048054, @Yevgeny Makarov (jenkm) wrote:

@Philipp Oeser (lichtwerk) But in the Properties editor, collapsing panels works without this problem.

What's the difference?

I assume panels expand/collapse consume the event right away (WM_UI_HANDLER_BREAK)

Philipp Oeser (lichtwerk) reopened this task as Needs Information from Developers.Nov 4 2020, 4:42 PM
Philipp Oeser (lichtwerk) removed Philipp Oeser (lichtwerk) as the assignee of this task.
Philipp Oeser (lichtwerk) added subscribers: Hans Goudey (HooglyBoogly), Nathan Craddock (natecraddock).
In T82397#1048057, @Tomasz Kaye (bitbutter) wrote:

seems it shouldn't be consumed as a double click if the underlying UI element (e.g. a twirl-down toggle) doesn't respond to double clicks. At least this is how all the other UIs i've used work.

Well, you also have the click-drag functionality over those icons that might have to do with this, not sure, havent checked.
Maybe @Zachman or @Hans Goudey (HooglyBoogly) think that we need to act here?

Nathan Craddock (natecraddock) added a comment.Nov 4 2020, 5:18 PM

The disclosure triangles are implemented as a modal operator, not icon buttons, so the modal isn't reacting to double click properly.

This morning I considered rewriting this code to use buttons (which I think would handle the double-click case) or we could maybe add a case in the keymap for double click.

I wouldn't consider this a bug though

Philipp Oeser (lichtwerk) added a comment.Nov 4 2020, 5:39 PM
In T82397#1048128, @Zachman wrote:

I wouldn't consider this a bug though

If you want to keep this as a TODO, please go ahead [or close otherwise]

Nathan Craddock (natecraddock) closed this task as Archived.Nov 4 2020, 5:40 PM
Nathan Craddock (natecraddock) claimed this task.

This currently works as intended, closing as known issue.