Page MenuHome
Create Task
Maniphest T83532

Sample to palette continues sampling brush color without useful effect
Closed, ArchivedPublic
Actions

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 451.67

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-12-05 13:56, hash: rB52a6c4f34d4a
Tested all the way back to 2.79, same problem.
Worked: 2.63

Description
After sampling color to palette while holding S key brush color is updated as well, but it is not set. Unset color is still visible in UI though.
See video:

Steps to reproduce

T83532.blend773 KBDownload

  1. Open file
  2. Press and hold S key to start sampling
  3. Press LMB to sample color to palette (don't release S key yet)
  4. Sample a bit more, brush color is updated
  5. Release S key
  6. Draw

Brush color will change to color before step 1.

Related Objects

Event Timeline

M (justastatue) created this task.Dec 8 2020, 12:32 AM
M (justastatue) mentioned this in T83533: Texture Paint : Sample Color redo panel stays when making brush strokes, can cause unintentional loss of work + related Sample Color redo panel bugs.Dec 8 2020, 12:35 AM
M (justastatue) updated the task description. (Show Details)
Richard Antalik (ISS) added a subscriber: Richard Antalik (ISS).Dec 11 2020, 1:09 PM

I can reproduce a bug, but I had to go over your report few times until I extracted what is the issue. So I will simplify report description a bit. Sorry if I miss something important.

Richard Antalik (ISS) renamed this task from Texture / Vertex Paint - Sample Color shortcut does not work to Sample to palette continues sampling brush color without useful effect.Dec 11 2020, 1:20 PM
Richard Antalik (ISS) changed the task status from Needs Triage to Confirmed.
Richard Antalik (ISS) updated the task description. (Show Details)
Richard Antalik (ISS) added a project: Sculpt, Paint & Texture.
M (justastatue) added a comment.Dec 11 2020, 9:40 PM

Sorry, I wasn't very concise, because I found the issue quite confusing...

Thank you for updating the description, it made me realize what's actually happening and what caused my confusion:
I've just realized that the Sample Color shortcut works without clicking.
You just press S to pick the color under your cursor. I didn't realize that.
I assumed the Sample Color operation worked like the Eyedropper operation (and color sampling in other software), where you click to pick a color, so I thought it was just completely broken.

I completely missed the status bar communicating that left clicking adds the color to the palette instead, which would have made it clear to me this is mainly a UI rendering problem.

Though the UI displaying the incorrect color is mainly what gave me this impression, I do also think that I think it's inherently confusing that the Eyedropper and Sample Color operations do almost the same exact thing but are controlled in contradictory ways: Eyedropper requires a left click to pick a color, Sample Color requires no left click...

Julien Kaspar (JulienKaspar) changed the task status from Confirmed to Needs Information from User.May 12 2022, 2:25 PM
Julien Kaspar (JulienKaspar) added a subscriber: Julien Kaspar (JulienKaspar).

I cannot reproduce this anymore. It might've already been fixed?

Richard Antalik (ISS) closed this task as Archived.Jun 24 2022, 7:13 PM

Also can't reproduce anymore so will close.