Page MenuHome

Texture Paint : Sample Color redo panel stays when making brush strokes, can cause unintentional loss of work + related Sample Color redo panel bugs
Closed, DuplicatePublic

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 451.67

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-12-05 13:56, hash: rB52a6c4f34d4a
Also tested in 2.85.3 LTS was a problem there too.
Worked, kind of: In 2.79, while the Sample Color redo panel is also available while painting after sampling a color, changing a parameter in it does not undo all painting done from when the color was sampled.

Description
These issues are related to this bug I just reported:
https://developer.blender.org/T83532

After sampling a color in texture paint mode, the redo panel will stay there while making brush strokes.
The consequence of this is that if you change a parameter in that redo panel after making some brush strokes, it will undo all brush strokes made since you originally sampled that color.
See here in this video, where I sample a color, draw something, then change a Sample Color parameter, and it undoes my drawing:

When vertex painting, the Sample Color redo panel disappears as soon as you do anything else, so this isn't a problem there.

I also found other bugs related to the Sample Color redo panel:

  • If you make Add to Palette off by default in the keymap entry for Sample Color, it will still be on by default when you perform the operation. Changing the default value for Sample Merged in the keymap does work though.
  • Even if you toggle Add to Palette off in the redo panel, the color will be added to the palette anyway.
  • On top of that, if you toggle it back on the redo panel, it will add the color to the palette again. If you keep toggling Add to Palette on and off in the redo panel, it will keep duplicating the color in the palette.

Exact steps for others to reproduce the error

  • Enter texture paint mode, sample a color using S + left click
  • Draw anything, using less strokes than the undo step limit.
  • Change a parameter in the Sample Color redo panel which should still be open