Page MenuHome
Create Task
Maniphest T83603

Change Brush size does not show Falloff gradient anymore
Closed, ArchivedPublic
Actions

Description

System Information
Operating system: Darwin-20.2.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 575 OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.2.11

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-12-07 22:51, hash: rBab9952e55fe1
Broken: 2.81
Worked: 2.80

Caused by rBbe985bdde27f: Sculpt: Sculpt cursor UX improvements

Short description of error
Change Brush size does not show Falloff gradient anymore

Exact steps for others to reproduce the error

  • Enter Texture Paint mode (or sculpt mode, vertexpaint mode, ...)
  • use F to change brush size: no falloff shown
  • use ⇧+F to change brush strength: falloff shown

This was not the case in 2.79 or 2.80

Turns out whenever radial control is used for something other than PROP_NONE, PROP_PIXEL, PROP_DISTANCE, it draws with the (falloff) gradient, in our case [brush size], it draws without. Think this is useful information which does not really distract?

Related Objects

Event Timeline

Kent Davis (mac4kent) created this task.Dec 9 2020, 10:18 PM
Kent Davis (mac4kent) added a comment.Dec 19 2020, 1:34 AM

Hello?

Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).Dec 22 2020, 3:26 PM

I also can't see the black Falloff circle here.
It must be by design.
I'm not sure if it's really a bug.

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Dec 22 2020, 4:12 PM
Philipp Oeser (lichtwerk) claimed this task.
Philipp Oeser (lichtwerk) added a project: Sculpt, Paint & Texture.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

It does display when a texture mask texture https://docs.blender.org/manual/en/dev/sculpt_paint/brush/texture.html#texture-mask is specified.
You can set one to pure white to get the desired effect, but maybe this could be done by default yes.

In Fact, 2.79 and 2.80 still did that, so I would confirm this.
Will also check on this.

Kent Davis (mac4kent) added a comment.Dec 22 2020, 4:37 PM

Push the 'F' key doesn't appear falloff black circle show display.
Push the 'Shift+F' yes show number and falloff black circle show display.
Push the 'Command+F' yes show number and fall black circle show display.

That is not TEXTURE PAINT.

Philipp Oeser (lichtwerk) removed Philipp Oeser (lichtwerk) as the assignee of this task.Dec 22 2020, 5:41 PM
Philipp Oeser (lichtwerk) added subscribers: Pablo Dobarro (pablodp606), Julien Kaspar (JulienKaspar), Jeroen Bakker (jbakker) and 2 others.

Seems like this was a somewhat intentional change in rBbe985bdde27f: Sculpt: Sculpt cursor UX improvements

Also see this comment in D5889

In D5889#135588, @Pablo Dobarro (pablodp606) wrote:
  • Hide gradient when resizing

So whenever radial control is used for something other than PROP_NONE, PROP_PIXEL, PROP_DISTANCE, it draws with the (falloff) gradient, in our case [brush size], it draws without.
Not sure I can follow that logic (think this is useful information which does not really distract), but will let module members decide...

Use this to always show it:

P1853 T83603 snippet
1
2
3diff --git a/source/blender/windowmanager/intern/wm_operators.c b/source/blender/windowmanager/intern/wm_operators.c
4index a5b5f082c41..07a0690a3f2 100644
5--- a/source/blender/windowmanager/intern/wm_operators.c
6+++ b/source/blender/windowmanager/intern/wm_operators.c
7@@ -2187,7 +2187,7 @@ static void radial_control_set_tex(RadialControl *rc)
8 if ((ibuf = BKE_brush_gen_radial_control_imbuf(
9 rc->image_id_ptr.data,
10 rc->use_secondary_tex,
11- !ELEM(rc->subtype, PROP_NONE, PROP_PIXEL, PROP_DISTANCE)))) {
12+ true))) {
13
14 rc->texture = GPU_texture_create_2d(
15 "radial_control", ibuf->x, ibuf->y, 1, GPU_R8, ibuf->rect_float);

CC @Pablo Dobarro (pablodp606)
CC @Julien Kaspar (JulienKaspar)
CC @Pablo Vazquez (pablovazquez)
CC @Jeroen Bakker (jbakker)
CC @Campbell Barton (campbellbarton)

Philipp Oeser (lichtwerk) renamed this task from Falloff (black middle circle) [F] key not appear show display to Change Brush size does not show Falloff gradient anymore.Dec 22 2020, 5:46 PM
Philipp Oeser (lichtwerk) updated the task description. (Show Details)
Philipp Oeser (lichtwerk) updated the task description. (Show Details)
Philipp Oeser (lichtwerk) updated the task description. (Show Details)Dec 22 2020, 5:49 PM
Kent Davis (mac4kent) added a comment.Dec 22 2020, 5:50 PM

Yes correct.

Pablo Dobarro (pablodp606) closed this task as Archived.Jan 22 2021, 12:41 AM

Using gradients to define a curve in the UI is rarely useful (you can't differentiate gray scale values with enough precision to determine the shape of the curve). This is why the curve preview with the line was added when changing the strength.
I consider this an UI design discussion, but in my opinion, the gradient falloff should be always hidden (maybe only show it multiplied on top of an alpha texture when it is being used).

Kent Davis (mac4kent) added a comment.Jan 22 2021, 12:58 AM

@Pablo Dobarro (pablodp606) Do you have your own Macintosh?

Kent Davis (mac4kent) added a comment.Jan 23 2021, 7:06 PM

@Philipp Oeser (lichtwerk) Thank you for your support to change rename correct. I am not good english to explain but why @Pablo Dobarro (pablodp606) put invalid without communication to me.
I ask him do they already inspect for Macintosh.

Germano Cavalcante (mano-wii) added a comment.Jan 25 2021, 3:52 PM

@Kent Davis (mac4kent), apparently the "Brush size gradient falloff" no longer showing was a design choice and not a bug.
The same is seen in other systems (not only Macintosh).

Since it is not really a bug (but something that was decided), the report has been closed.

Kent Davis (mac4kent) added a comment.Jan 25 2021, 3:56 PM

@Germano Cavalcante (mano-wii) Thank you for explain me.