Adjust the decision making for result attribute types
Closed, ResolvedPublicTO DO
Actions

Description

Nodes like the Attribute Color Ramp node would usually output a color. However, if the result attribute exists already and is e.g. of type Float, we want that the attribute remains of type float.
Currently the attribute is first removed and then recreated with a new type.

This makes the type of an attribute more consistent, because nodes usually do not change the type of attributes, unless they are explicitly asked to do so. Furthermore, this allows us to use the same attribute as input and output in a node more often. (e.g. in the Attribute Color Ramp node, the input and output attribute could be the same)

Revisions and Commits

rB Blender
	D10109	rBe5ee7e9a2df9 Geometry Nodes: don't delete existing attribute before new attribute is computed
	D10099	rB719bea0d6d06 Geometry Nodes: Output the most complex attribute data type

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	TO DO	Dalai Felinto (dfelinto)	T83793 Adjust the decision making for result attribute types
		Resolved	BUG	Hans Goudey (HooglyBoogly)	T83906 Scaling the scale attribute after attribute mix node

Event Timeline

Jacques Lucke (JacquesLucke) created this task.Dec 15 2020, 11:53 AM

Perhaps integer, float and bool should all be floats internally?

I don't think this is a good idea... Also, what would it solve?

Dalai Felinto (dfelinto) moved this task from Product Backlog to Next Release Targets on the Geometry Nodes board.Jan 12 2021, 2:34 PM

Proposal from me and @Hans Goudey (HooglyBoogly).

If an input and an output attribute have the same name but different type, first compute the new attribute, before deleting the old one.

Attribute Math: Always output float.
Attribute Compare: Always output boolean.
Attribute Mix: Have a output type dropdown (including Auto option).
Attribute Color Ramp: Same as Attribute Mix.
Attribute Vector Math: Output type depends on the operation.

Jacques Lucke (JacquesLucke) added a project: BF Blender (2.92).Jan 12 2021, 3:27 PM

We decided to use the Auto option implicitly for Attribute Mix, Attribute Color Ramp and only add an enum later if there is a need for it.
The other points mentioned in the proposal are good.

Hans Goudey (HooglyBoogly) added a revision: D10099: Geometry Nodes: Output with the most complex attribute data type.Jan 12 2021, 8:38 PM

Hans Goudey (HooglyBoogly) renamed this task from Do not change data type of result attribute if it exists already to Adjust the decision making for result attribute types.Jan 12 2021, 8:55 PM

Hans Goudey (HooglyBoogly) mentioned this in T84628: Sine mode of attribute vector math node.

Hans Goudey (HooglyBoogly) added a subtask: T83906: Scaling the scale attribute after attribute mix node.

Hans Goudey (HooglyBoogly) added a commit: rB719bea0d6d06: Geometry Nodes: Output the most complex attribute data type.Jan 12 2021, 9:04 PM

Hans Goudey (HooglyBoogly) moved this task from Next Release Targets to In Progress on the Geometry Nodes board.Jan 12 2021, 9:18 PM

Jacques Lucke (JacquesLucke) mentioned this in rB614bd239f852: Geometry Nodes: support optional ownership for typed attributes.Jan 13 2021, 10:49 AM

Hans Goudey (HooglyBoogly) moved this task from Backlog to bcon2: Features on the BF Blender (2.92) board.Jan 13 2021, 2:34 PM

Jacques Lucke (JacquesLucke) mentioned this in D10109: Geometry Nodes: Support computing new attribute before deleting old one..Jan 14 2021, 1:00 PM

Jacques Lucke (JacquesLucke) added a commit: rBe5ee7e9a2df9: Geometry Nodes: don't delete existing attribute before new attribute is computed.Jan 14 2021, 3:53 PM

Hans Goudey (HooglyBoogly) closed subtask T83906: Scaling the scale attribute after attribute mix node as Resolved.Jan 15 2021, 11:57 PM