Page MenuHome
Create Task
Maniphest T84002

Sculpt: Masking operations crash if multires is in play
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-12-19 06:25, hash: rBa5a302bd1806
Worked: 2.91
Caused by rB90e12e823ff0: Fix T81854: crash when undoing switch between sculpt and edit mode.

Short description of error
Sculpt: Masking operations crash if multires is in play

Exact steps for others to reproduce the error

  • add a multiresolution modifier to the default cube
  • subdivide (at least) once
  • with the mask brush: do a stroke [should crash]
  • OR: do a box mask
  • OR: clear a mask

Revisions and Commits

rB Blender
rBd29a720c45e5 Fix T84002: Sculpt: Masking operations crash if multires is in play.

Related Objects

Event Timeline

Nathan (NWNWN) created this task.Dec 21 2020, 12:48 AM
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Dec 21 2020, 10:42 AM
Philipp Oeser (lichtwerk) claimed this task.
Philipp Oeser (lichtwerk) added a project: Sculpt, Paint & Texture.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Can confirm, checking.

Robert Guetzkow (rjg) added a subscriber: Robert Guetzkow (rjg).Dec 21 2020, 10:53 AM

I can reproduce this issue with the provided file, but couldn't with the sculpting application template.

sculpt_undo_store_mask(Object * ob, SculptUndoNode * unode) (/home/dev/01-data/01-git/blender-git/blender/source/blender/editors/sculpt_paint/sculpt_undo.c:1101)
SCULPT_undo_push_node(Object * ob, PBVHNode * node, SculptUndoType type) (/home/dev/01-data/01-git/blender-git/blender/source/blender/editors/sculpt_paint/sculpt_undo.c:1306)
mask_flood_fill_task_cb(void * restrict userdata, const int i, const TaskParallelTLS * restrict UNUSED_tls) (/home/dev/01-data/01-git/blender-git/blender/source/blender/editors/sculpt_paint/paint_mask.c:132)
RangeTask::operator()(tbb::blocked_range<int> const&) const::{lambda()#1}::operator()() const(const RangeTask::<lambda()> * const __closure) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenlib/intern/task_range.cc:96)
tbb::interface7::internal::delegated_function<RangeTask::operator()(tbb::blocked_range<int> const&) const::{lambda()#1} const, void>::operator()() const(const tbb::interface7::internal::delegated_function<const RangeTask::operator()(const tbb::blocked_range<int>&) const::<lambda()>, void> * const this) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task_arena.h:93)
tbb::interface7::internal::isolate_within_arena(tbb::interface7::internal::delegate_base&, long) (Unknown Source:0)
tbb::interface7::internal::isolate_impl<void, RangeTask::operator()(tbb::blocked_range<int> const&) const::{lambda()#1} const>(RangeTask::operator()(tbb::blocked_range<int> const&) const::{lambda()#1} const&)(const RangeTask::<lambda()> & f) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task_arena.h:160)
tbb::interface7::this_task_arena::isolate<RangeTask::operator()(tbb::blocked_range<int> const&) const::{lambda()#1}>(tbb::interface7::internal::return_type_or_void const&)(const RangeTask::<lambda()> & f) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/task_arena.h:395)
RangeTask::operator()(const RangeTask * const this, const tbb::blocked_range<int> & r) (/home/dev/01-data/01-git/blender-git/blender/source/blender/blenlib/intern/task_range.cc:92)
tbb::interface9::internal::start_for<tbb::blocked_range<int>, RangeTask, tbb::auto_partitioner const>::run_body(tbb::interface9::internal::start_for<tbb::blocked_range<int>, RangeTask, tbb::auto_partitioner const> * const this, tbb::blocked_range<int> & r) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/parallel_for.h:115)
tbb::interface9::internal::dynamic_grainsize_mode<tbb::interface9::internal::adaptive_mode<tbb::interface9::internal::auto_partition_type> >::work_balance<tbb::interface9::internal::start_for<tbb::blocked_range<int>, RangeTask, tbb::auto_partitioner const>, tbb::blocked_range<int> >(tbb::interface9::internal::dynamic_grainsize_mode<tbb::interface9::internal::adaptive_mode<tbb::interface9::internal::auto_partition_type> > * const this, tbb::interface9::internal::start_for<tbb::blocked_range<int>, RangeTask, tbb::auto_partitioner const> & start, tbb::blocked_range<int> & range) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/partitioner.h:438)
tbb::interface9::internal::partition_type_base<tbb::interface9::internal::auto_partition_type>::execute<tbb::interface9::internal::start_for<tbb::blocked_range<int>, RangeTask, tbb::auto_partitioner const>, tbb::blocked_range<int> >(tbb::interface9::internal::partition_type_base<tbb::interface9::internal::auto_partition_type> * const this, tbb::interface9::internal::start_for<tbb::blocked_range<int>, RangeTask, tbb::auto_partitioner const> & start, tbb::blocked_range<int> & range) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/partitioner.h:256)
tbb::interface9::internal::start_for<tbb::blocked_range<int>, RangeTask, tbb::auto_partitioner const>::execute(tbb::interface9::internal::start_for<tbb::blocked_range<int>, RangeTask, tbb::auto_partitioner const> * const this) (/home/dev/01-data/01-git/blender-git/lib/linux_centos7_x86_64/tbb/include/tbb/parallel_for.h:142)
tbb::internal::custom_scheduler<tbb::internal::IntelSchedulerTraits>::process_bypass_loop(tbb::internal::context_guard_helper<false>&, tbb::task*, long) (Unknown Source:0)
tbb::internal::custom_scheduler<tbb::internal::IntelSchedulerTraits>::local_wait_for_all(tbb::task&, tbb::task*) (Unknown Source:0)
tbb::internal::arena::process(tbb::internal::generic_scheduler&) (Unknown Source:0)
tbb::internal::market::process(rml::job&) (Unknown Source:0)
tbb::internal::rml::private_worker::run() (Unknown Source:0)
tbb::internal::rml::private_worker::thread_routine(void*) (Unknown Source:0)
libpthread.so.0!start_thread(void * arg) (/build/glibc-ZN95T4/glibc-2.31/nptl/pthread_create.c:477)
Philipp Oeser (lichtwerk) triaged this task as High priority.EditedDec 21 2020, 11:51 AM
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".

In fact, any masking operation crashes since rB90e12e823ff0: Fix T81854: crash when undoing switch between sculpt and edit mode. if multires is in play

Philipp Oeser (lichtwerk) renamed this task from Clear mask in sculpt mode crashes to Sculpt: Masking operations crash if multires is in play.Dec 21 2020, 11:55 AM
Philipp Oeser (lichtwerk) updated the task description. (Show Details)
Philipp Oeser (lichtwerk) removed Philipp Oeser (lichtwerk) as the assignee of this task.Dec 21 2020, 12:04 PM
Philipp Oeser (lichtwerk) added a subscriber: Bastien Montagne (mont29).

@Bastien Montagne (mont29): I assume you are quicker here: mind having a look?

Bastien Montagne (mont29) added a subscriber: Sergey Sharybin (sergey).Dec 22 2020, 5:47 PM

This is actually a nightmare of several entangled issues, involving very, very bad code and general architecture of sculpt mode...

Will probably have some patches ready by tomorrow, but we'll have to wait for @Sergey Sharybin (sergey) since some involve multires and am highly unsure I fully grasp the whole picture there.

Bastien Montagne (mont29) mentioned this in T84084: Assert/crash during COW phase of depsgraph evaluation due to mismatch mask info in code updating mesh data from multires subdiv ccg runtime data..Dec 23 2020, 4:00 PM
Bastien Montagne (mont29) closed this task as Resolved by committing rBd29a720c45e5: Fix T84002: Sculpt: Masking operations crash if multires is in play..Dec 23 2020, 4:06 PM
Bastien Montagne (mont29) claimed this task.
Bastien Montagne (mont29) added a commit: rBd29a720c45e5: Fix T84002: Sculpt: Masking operations crash if multires is in play..
Philipp Oeser (lichtwerk) mentioned this in T85065: Sculpt Mode - Using Mask while Multiress active = Crash.Jan 26 2021, 12:20 PM