Page MenuHome

Sculpt mode undoes texture color space when undoing stroke
Closed, ResolvedPublic

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.79

Blender Version
Broken: version: 2.91.0, branch: master (modified), commit date: 2020-11-25 11:06, hash: rBb50598bc78c7
Worked: (newest version of Blender that worked as expected)

Short description of error
When performing undo during sculpting in Blender 2.91, the undo undoes last changed UI parameter alongside last stroke when pressing undo shortcut (Ctrl+Z). In this particular illustrated instance, color space of a newly loaded image texture. But in general, it undoes almost anything made prior to the first stroke, such as brush size, etc...

Exact steps for others to reproduce the error

  1. Open the attached .blend file:
  2. Enter sculpt mode on the selected object.
  3. Load another texture to be used as a brush texture, as seen in the video
  4. The texture color space will incorrectly revert to sRGB, change it back to linear.
  5. Make a sculpt brush stroke on the mesh
  6. Undo the stroke

Result: Undo undoes the stroke, but color space change at the same time.
Expected: Undo undoes only the brush stroke.

Event Timeline

Here is an extreme case, where it undoes !4! changes at once:

1, Setting texture to be linear.
2, Setting stroke mode to be anchored.
3, Increasing brush strength.
4, Performing a brush stroke

The single undo press erases all 4 changes above. This really makes sculpting mode pretty much unusable. This needs to be hotfixed.

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Jan 21 2021, 4:38 PM
Philipp Oeser (lichtwerk) changed the task status from Confirmed to Needs Information from User.Jan 21 2021, 4:44 PM

Sorry, was testing on the wrong blender version.

In a fresh build, this should be fixed by rBbc0a6b0400ce: Fix T71759: Sculpt/Vertex/Weight Paint Brush Size Gets Undone After Undoing a…, right?

So please check again in a fresh build from https://builder.blender.org/download/ and report back if this issue is fixed for you as well, thx.

Sorry, was testing on the wrong blender version.

In a fresh build, this should be fixed by rBbc0a6b0400ce: Fix T71759: Sculpt/Vertex/Weight Paint Brush Size Gets Undone After Undoing a…, right?

So please check again in a fresh build from https://builder.blender.org/download/ and report back if this issue is fixed for you as well, thx.

Yes, it seems fixed now in 2.92. You can close this now. Although this can lead to data loss, so this definitely belongs into a hotfix (2.91.X) rather than having users waiting a long time for 2.92, which will fix this one but introduce many new bugs.

Philipp Oeser (lichtwerk) closed this task as Resolved.Jan 22 2021, 2:21 PM
Philipp Oeser (lichtwerk) claimed this task.

OKi, will close.

Dont think there will be another 2.91.X though?
And even if, I am not sure this would been in the "critical fix" category. I know though that this has been a pain for users for a really long time.