Page MenuHome

Crash editing properties
Closed, ResolvedPublic

Description

System Information
Operating system: Linux-5.8.0-7630-generic-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.32.03

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-02-01 16:28, hash: rB59054d906fa9
Worked: (newest version of Blender that worked as expected)

Short description of error
Changing the render and viewport samples in cycles crashes

Exact steps for others to reproduce the error

  1. Download the attached file (from T85304, thanks to @Simon Thommes (simonthommes))
  2. Use for a bit, the file should crash shortly


Original description:
I'm getting a crash while on workbench viewport just by changing the cycles samples number.

Note: Currently working on producing a test file since this happens on complex linked production files

Reproducible both in win and lin

hash: rB59054d906fa9

Thread 1 "blender" received signal SIGSEGV, Segmentation fault.
0x000000000e3f4e33 in ghash_keyhash (key=0x7fffffffcf50, gh=0x0) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:148
148	  return gh->hashfp(key);
(gdb) bt
#0  0x000000000e3f4e33 in ghash_keyhash (key=0x7fffffffcf50, gh=0x0) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:148
#1  ghash_lookup_entry (key=0x7fffffffcf50, gh=0x0) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:427
#2  BLI_ghash_lookup (gh=0x0, key=0x7fffffffcf50) at /home/zanqdo/Software/blender-git/blender/source/blender/blenlib/intern/BLI_ghash.c:805
#3  0x000000000357fe5d in BKE_scene_get_depsgraph (scene=0x7fff4f3f3808, view_layer=0x7fff6f079b08)
    at /home/zanqdo/Software/blender-git/blender/source/blender/blenkernel/intern/scene.c:3462
#4  0x0000000003d1b1e6 in DRW_cache_free_old_batches (bmain=0x7fffc7a7e708) at /home/zanqdo/Software/blender-git/blender/source/blender/draw/intern/draw_manager.c:994
#5  0x0000000004c79c5d in view3d_main_region_draw (C=0x7ffff4710f88, region=0x7fffab5e1988)
    at /home/zanqdo/Software/blender-git/blender/source/blender/editors/space_view3d/view3d_draw.c:1626
#6  0x0000000004522c9e in ED_region_do_draw (C=0x7ffff4710f88, region=0x7fffab5e1988) at /home/zanqdo/Software/blender-git/blender/source/blender/editors/screen/area.c:558
#7  0x0000000003a231f8 in wm_draw_window_offscreen (C=0x7ffff4710f88, win=0x7fffaee67208, stereo=false)
    at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:731
#8  0x0000000003a237b9 in wm_draw_window (C=0x7ffff4710f88, win=0x7fffaee67208) at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:872
#9  0x0000000003a23e05 in wm_draw_update (C=0x7ffff4710f88) at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm_draw.c:1073
#10 0x0000000003a203b2 in WM_main (C=0x7ffff4710f88) at /home/zanqdo/Software/blender-git/blender/source/blender/windowmanager/intern/wm.c:643
#11 0x0000000003404bd5 in main (argc=1, argv=0x7fffffffdf38) at /home/zanqdo/Software/blender-git/blender/source/creator/creator.c:522

Log file from merged ticket T85272



Event Timeline

Daniel Salazar (zanqdo) renamed this task from Crash editing render properties to Crash editing properties.Feb 1 2021, 10:04 PM
Robert Guetzkow (rjg) changed the task status from Needs Triage to Needs Information from User.EditedFeb 1 2021, 10:23 PM

I was unable to reproduce this on both Windows and Linux. As already mentioned in the discussion on blender.chat, since this only appears to happen in particular project files we would need a minimal example project that allows us to reproduce the problem.

If you want to investigate this yourself, I would suggest you create a developer build on Linux with ASAN. This should allow you to catch potential issues early on.

Should you really be unable to create a shareable project that demonstrates the issue, please try to bisect the commit that introduced the problem.

@Rainer Trummer (aliasguru) Based on the stack trace you are experiencing the same issue. Please try to find a minimal example project as well. You are likely able to remove most objects since they won't all be relevant to the issue and perhaps this would allow you to share the file.

@Brecht Van Lommel (brecht) it seems the recent changes made to BKE_scene_get_depsgraph in rB087777f2b9b8c7cfc75458c6e6e714e92e2e2851 could have caused this (or revealed another issue that existed before).

The null pointer check should have been fixed in rB30ac21bf339.

Robert Guetzkow (rjg) updated the task description. (Show Details)

@Sergey Sharybin (sergey) looks like that commit has been committed to the release branch but not to master.

@Falk David (filedescriptor) It's in master with the referenced hash, but it doesn't solve the issue from this ticket. 2.93.0 Alpha, branch: master, commit date: 2021-02-02 08:36, hash: rB356c62fe3226

The commit itself is in master branch indeed, but the code is not. Not sure how that is possible, so I've re-committed the fix from Clement in master again (rBd19aaad0bce).

Can confirm this fixed the crashes for me. Not sure about @Daniel Salazar (zanqdo)

That fixes the issue indeed, which seems obvious given the stack trace. Strange, looks like something went wrong with the original merge rB9c244820d1cb8d80ce1c7110a9f1580e3010e4e9.

Robert Guetzkow (rjg) closed this task as Resolved.Feb 2 2021, 12:03 PM
Robert Guetzkow (rjg) claimed this task.

Thanks guys, I was trying to produce a crash file but it was very difficult since it kept crashing on save xD

cheers!

@Daniel Salazar (zanqdo), is the crash on save reported as a bug?

@Daniel Salazar (zanqdo), is the crash on save reported as a bug?

I think it was the same bug! Does not crash now