Page MenuHome

Lookup for attribute search
Closed, ResolvedPublicTO DO

Description

Depends on T85656 and T85657.

Full design reference: T85280

The eye-candy can (should) be done as a separate pass.

Event Timeline

Okay, I've been fighting with the UI code for a while, time to write some things down.

There are two general approaches I've been trying:

The first is to build an RNA collection with the available attributes and store it in the socket or the node. This approach might simplify the UI code a bit.
However, generating the list of attributes requires the context (to fetch the proper NodeUIStorage from the context map), and as far as I can tell, RNA collection callbacks do not have a way to use the context.
So in order to use this method, we need to add a runtime pointer to the proper NodeUIStorage to every node socket. Then those data structures would be exposed to RNA.

The other approach, what I'm working on now, is more direct, and lower level, simply creating the search button directly in the C/C++ code. This avoids exposing anything to RNA, which probably lowers the total amount of changes considerably.
I've ran into some problems with this approach so far, but I'm working through them, so we'll see how it works.

I have some work in progress code in temp-geometry-nodes-attribute-search. rB45f6c9bd0533 explains some of the current issues.

Here's a quick screenshot of the initial version, for reference:

Dalai Felinto (dfelinto) closed this task as Resolved.Mar 8 2021, 12:33 PM