Page MenuHome
Create Task
Maniphest T87263

Grease Pencil. Can't animate Factor value of Build modifier.
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-04-06 21:02, hash: rBe0a1a2f49dab

Short description of error
I can't add keyframes to animate the Factor value of Build modifier.

Exact steps for others to reproduce the error

  • Create new 2D animation file
  • Draw a stroke
  • Add The Build modifier to the current Grease Pencil object.
  • Enable the 'Use Factor' checkbox of the Modifier.
  • Click the 'Animate property' dot to the right of the Factor slider.
  • Move the playhead to a later frame.
  • Drag the Factor slider to 100.
  • Click the empty diamond to the right of the Factor slider to add a new keyframe.
  • 'Restrict Visible Points' keyframes have been created, but 'Factor' Keyframes haven't, the build effect doesn't animate.

Revisions and Commits

rB Blender
D10910rB7c04ef210e0e Fix T87263: Animation decorator not working on Grease Pencil Build modifier…

Event Timeline

Tomasz Kaye (bitbutter) created this task.Apr 7 2021, 11:20 AM
Tomasz Kaye (bitbutter) added a project: Grease Pencil.
Tomasz Kaye (bitbutter) updated the task description. (Show Details)Apr 7 2021, 11:23 AM
Philipp Oeser (lichtwerk) claimed this task.Apr 7 2021, 11:32 AM
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Yes, I guess the animation decorator should act on the Factor value slider instead of the Use Factor checkbox.
Will check on this.

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Apr 7 2021, 11:33 AM
Philipp Oeser (lichtwerk) added a revision: D10910: Fix T87263: Animation decorator not working on Grease Pencil Build modifier Factor value.Apr 7 2021, 12:30 PM
Philipp Oeser (lichtwerk) added projects: User Interface, Modifiers.Apr 7 2021, 12:31 PM
Tomasz Kaye (bitbutter) awarded a token.Apr 7 2021, 12:39 PM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).EditedApr 7 2021, 1:08 PM

I need to look at the code, but IIRC some values cannot be animated because the build modifier need to calculate several values "before" do anything, so some values cannot change in the midle of the animation. If this is the reason, the solution is remove the animation flag in this values.

Edit: I have looked and this value can be animated. The problem is the decorator key icon is not working as expected, but if the animation is done using I over value works.

Philipp Oeser (lichtwerk) closed this task as Resolved by committing rB7c04ef210e0e: Fix T87263: Animation decorator not working on Grease Pencil Build modifier….Apr 7 2021, 6:47 PM
Philipp Oeser (lichtwerk) added a commit: rB7c04ef210e0e: Fix T87263: Animation decorator not working on Grease Pencil Build modifier….
Tomasz Kaye (bitbutter) added a comment.Apr 8 2021, 12:50 PM

With the new change, if i have 'Use Factor' turned on, i expected 'start delay' and 'frames' values to be ignored. but currently the animation (driven by the Factor value) only happens within the part of the timeline specified by the 'Frames' and 'Delay' values.

Philipp Oeser (lichtwerk) added a comment.Apr 8 2021, 1:01 PM
In T87263#1142819, @Tomasz Kaye (bitbutter) wrote:

With the new change, if i have 'Use Factor' turned on, i expected 'start delay' and 'frames' values to be ignored. but currently the animation (driven by the Factor value) only happens within the part of the timeline specified by the 'Frames' and 'Delay' values.

That is not touched by this commit (that is just unfortunate design of this modifier and has been present before).
Please report this separately so this can be looked at.