Page MenuHome
Create Task
Maniphest T87297

Grease Pencil Build Modifier: 'Frames' and 'Start Delay' values should be ignored when 'Use Factor' is checked.
Closed, ResolvedPublicTO DO
Actions

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-04-07 21:03, hash: rBb7b1b2325c1a

Short description of error
For the Grease Pencil Build Modifier: 'Frames' and 'Start Delay' values should be ignored when 'Use Factor' is checked. Currently, with Use Factor checked, animating the Factor value only influences the artwork within the range of frames implied by the Start Delay and Frames values. If users are manually animating the effect with Use Factor i believe these other values should not affect the result (can't think of a use case for wanting them to).

Exact steps for others to reproduce the error

  • Draw a grease pencil stroke
  • Add the build modifier
  • Turn on 'Use Factor' on the modifier.
  • Add a Factor keyframe at frame 0, set to 0.0
  • Add a Factor keyframe at frame 10, set to 1.0
  • Set the Frames value of the modifier to 5
  • The modifier affects the stroke only until frame 5, the rest of the animation is ignored.

Revisions and Commits

rB Blender
rBbcf524328ff2 Fix T87297: Gpencil - Disable Frames and Start delay when use Factor

Event Timeline

Tomasz Kaye (bitbutter) created this task.Apr 8 2021, 1:21 PM
Tomasz Kaye (bitbutter) added a project: Grease Pencil.
Tomasz Kaye (bitbutter) updated the task description. (Show Details)
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Needs Information from Developers.Apr 8 2021, 1:29 PM
Philipp Oeser (lichtwerk) added subscribers: Antonio Vazquez (antoniov), Philipp Oeser (lichtwerk).

@Antonio Vazquez (antoniov) : your call on how to proceed (I can still see a usecase for using both at the same time -- if you only want to rely on the factor, you can just set frames to a really high number, we could also allow setting frames to zero [with the effect that this is then not limiting at all])

Antonio Vazquez (antoniov) added subscribers: Matias Mendiola (mendio), Daniel Martinez Lara (pepeland).Apr 8 2021, 3:23 PM

Here we need the opinion of @Matias Mendiola (mendio) and @Daniel Martinez Lara (pepeland). What do you think about these parameters?

Antonio Vazquez (antoniov) claimed this task.Apr 29 2021, 4:34 PM
Antonio Vazquez (antoniov) changed the task status from Needs Information from Developers to Confirmed.Apr 29 2021, 4:37 PM
Antonio Vazquez (antoniov) changed the subtype of this task from "Report" to "To Do".
Antonio Vazquez (antoniov) closed this task as Resolved by committing rBbcf524328ff2: Fix T87297: Gpencil - Disable Frames and Start delay when use Factor.Apr 29 2021, 5:01 PM
Antonio Vazquez (antoniov) added a commit: rBbcf524328ff2: Fix T87297: Gpencil - Disable Frames and Start delay when use Factor.