Page MenuHome

Crash when creating reroute loop in geometry nodes
Closed, ResolvedPublicBUG

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 2070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.63

Blender Version
Broken: version: 2.93.0 Beta, branch: master, commit date: 2021-04-19 20:39, hash: rB0566ebdebeeb
Worked: (newest version of Blender that worked as expected)

Short description of error
When a reroute loop is created in geometry nodes, I.e. connecting a reroute to another reroute that connects to it through any number of reroutes, blender crashes. In shader nodes, this is not a problem, as the new wire is turned red with no effect. This seems to happen with any number of reroutes, even 2.
Exact steps for others to reproduce the error
(from the default startup)

  1. Open blender
  2. Open a geometry nodes editor
  3. Create 2 reroutes
  4. Connect the first one to the second one
  5. Connect the second one to the first one

Event Timeline

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Apr 21 2021, 2:50 PM
Philipp Oeser (lichtwerk) claimed this task.

Can confirm, will check.

Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".Apr 21 2021, 2:50 PM
Philipp Oeser (lichtwerk) triaged this task as High priority.

Caused by rB0ff3f96a1b01: Nodes: make derived link data more obvious in NodeTreeRef

Seems to hang infinitely in blender::nodes::InputSocketRef::foreach_logical_origin.
Seems quicker if @Jacques Lucke (JacquesLucke) has a look.
Will set to High prio since it is a regression, crashes and we have the culprit commit.