Page MenuHome
Create Task
Maniphest T88787

Grease Pencil. Draw tool pressure - curve widget button missing?
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 457.30

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-05-16 05:49, hash: rB0e581f619670

Short description of error
The Blender manual for the Grease Pencil draw tool says:

Use Pressure (pressure sensitivity icon)
Uses stylus pressure to control how strong the effect is. The gradient of the pressure can be customized using the curve widget.

But I see no button (or any other way) to access a curve widget for mapping the draw tool's pressure. Should there be one?

Revisions and Commits

rB Blender
rB9ba6b64efa3a Greasepencil: show pressure curve widgets in the sidebar

Related Objects

Event Timeline

Tomasz Kaye (bitbutter) created this task.Jun 3 2021, 12:00 PM
Tomasz Kaye (bitbutter) added a project: Grease Pencil.Jun 3 2021, 12:03 PM
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Needs Information from User.Jun 3 2021, 1:58 PM
Philipp Oeser (lichtwerk) added subscribers: Antonio Vazquez (antoniov), Philipp Oeser (lichtwerk).

For some reason these were re-organized to only show in the Properties Editor in rBb571516237a9: GPencil: Include new Brush random curves

@Antonio Vazquez (antoniov): wouldnt it make much more sense to have these in the sidebar as well? What was the reasoning to exclude the curves from there?

Philipp Oeser (lichtwerk) changed the task status from Needs Information from User to Needs Information from Developers.Jun 3 2021, 1:58 PM
Philipp Oeser (lichtwerk) added a comment.Jun 3 2021, 2:09 PM

This would also show the curve widget in the sidebar:

P2153 T88787_snippet
1
2
3diff --git a/release/scripts/startup/bl_ui/properties_paint_common.py b/release/scripts/startup/bl_ui/properties_paint_common.py
4index f3462dfb35d..f96df8843d9 100644
5--- a/release/scripts/startup/bl_ui/properties_paint_common.py
6+++ b/release/scripts/startup/bl_ui/properties_paint_common.py
7@@ -1235,7 +1235,7 @@ def brush_basic_gpencil_paint_settings(layout, context, brush, *, compact=False)
8 row.prop(brush, "size", text="Radius")
9 row.prop(gp_settings, "use_pressure", text="", icon='STYLUS_PRESSURE')
10
11- if gp_settings.use_pressure and context.area.type == 'PROPERTIES':
12+ if gp_settings.use_pressure:
13 col = layout.column()
14 col.template_curve_mapping(gp_settings, "curve_sensitivity", brush=True,
15 use_negative_slope=True)
16@@ -1244,7 +1244,7 @@ def brush_basic_gpencil_paint_settings(layout, context, brush, *, compact=False)
17 row.prop(gp_settings, "pen_strength", slider=True)
18 row.prop(gp_settings, "use_strength_pressure", text="", icon='STYLUS_PRESSURE')
19
20- if gp_settings.use_strength_pressure and context.area.type == 'PROPERTIES':
21+ if gp_settings.use_strength_pressure:
22 col = layout.column()
23 col.template_curve_mapping(gp_settings, "curve_strength", brush=True,
24 use_negative_slope=True)

Matias Mendiola (mendio) added a subscriber: Matias Mendiola (mendio).Jun 3 2021, 2:46 PM

Grease pencil brushes have a lot of curve widgets, not just Radius and Strength (see random settings for example), the decision was to keep as clean as possible the topbar only with the toggle buttons to activate the use of the tablet preassure and put all the curve widget in properties. Those settings are for advanced user and is not something that need tweaking very often.

Tomasz Kaye (bitbutter) closed this task as Resolved.Jun 3 2021, 3:01 PM
Tomasz Kaye (bitbutter) claimed this task.

Thanks for the clarification! i'll close the ticket if everyone's ok with that

Philipp Oeser (lichtwerk) added a comment.Jun 3 2021, 3:14 PM

Was not talking about the top bar, I was refering to the discrepancy between the Properties Editor and the sidebar (they are available in the Properties Editor but not the sidebar -- which I find confusing):

Matias Mendiola (mendio) added a comment.Jun 3 2021, 3:27 PM

I see, in that case it seems to be an omission when all the widgets were moved to properties. @Antonio Vazquez (antoniov) could you take a look?

Tomasz Kaye (bitbutter) mentioned this in D11475: Added info on how to find curve widgets for active brush tool.Jun 3 2021, 3:32 PM
Antonio Vazquez (antoniov) added a comment.Jun 3 2021, 4:56 PM

@Philipp Oeser (lichtwerk) This looks that we missed to add these properties to the panel or that we decided to avoid too many things, don't remember now, but .if @Matias Mendiola (mendio) agrees in the UI side, your patch is ok.

Matias Mendiola (mendio) added a comment.Jun 3 2021, 6:13 PM
In T88787#1170426, @Antonio Vazquez (antoniov) wrote:

@Philipp Oeser (lichtwerk) This looks that we missed to add these properties to the panel or that we decided to avoid too many things, don't remember now, but .if @Matias Mendiola (mendio) agrees in the UI side, your patch is ok.

Sure, properties and side panel should work the same

Antonio Vazquez (antoniov) added a comment.Jun 3 2021, 8:04 PM

@Philipp Oeser (lichtwerk) do you commit the change or I can do it if you can't?

Philipp Oeser (lichtwerk) added a comment.Jun 3 2021, 8:24 PM

will do tomorrow

Philipp Oeser (lichtwerk) added a commit: rB9ba6b64efa3a: Greasepencil: show pressure curve widgets in the sidebar.Jun 4 2021, 12:20 PM