Page MenuHome
Create Task
Maniphest T89272

Visible column search for the spreadsheet
Confirmed, NormalPublicTO DO
Actions

Description

For creating row filters, the workflow would be much faster if we could select from a list of currently visible columns in the "Column Name" text box. This would act like attribute search, but only show columns from the current data set.

An implementation would probably create a dynamic read-only "visible columns" RNA collection property, and change the text box into a search box for that collection.

Related Objects

Event Timeline

Hans Goudey (HooglyBoogly) changed the task status from Needs Triage to Confirmed.Jun 18 2021, 10:56 PM
Hans Goudey (HooglyBoogly) created this task.
Hans Goudey (HooglyBoogly) mentioned this in T86133: Rules based row filtering for attribute spreadsheet.Jun 18 2021, 11:03 PM
Hans Goudey (HooglyBoogly) mentioned this in D10959: Spreadsheet Editor: Row filters.
Hans Goudey (HooglyBoogly) mentioned this in rBf9aea19d9890: Spreadsheet Editor: Row Filters.Jun 18 2021, 11:33 PM
Hans Goudey (HooglyBoogly) moved this task from Product Backlog to Community Tasks on the Geometry Nodes board.Jul 19 2021, 12:31 AM
Hans Goudey (HooglyBoogly) added a project: Nodes & Physics.Jul 19 2021, 2:39 PM
Johnny Matthews (guitargeek) added a subscriber: Johnny Matthews (guitargeek).Aug 12 2021, 2:25 PM
Hans Goudey (HooglyBoogly) added a subscriber: Jacques Lucke (JacquesLucke).Aug 12 2021, 7:24 PM

Johnny asked for some hints of where to start. I'm not sure exactly how I would do this (it's a bit less straightforward than I expected), but I have an idea:

  1. Define a new collection property for the spreadsheet in rna_space.c-- a collection of SpreadSheetColumnIDs.
  2. The collection should be a "runtime" collection, i.e. not stored in SpaceSpreadsheet in DNA.
    • RNA_def_property_collection_funcs will be important here, with a custom iterator implementation using CollectionPropertyIterator.
    • Searching for that RNA function gives quite a few examples of custom iterators.
  3. uiItemPointerR should be used in place of the current filter "name" property in the UI.

It's the iterator for visible columns that's making me unsure at the moment. The spreadsheet code is in a half-way state currently, where SpreadSheetColumn is meant to be persistent but isn't really
Do you have a thought about that part @Jacques Lucke (JacquesLucke)?

Iliya Katueshenock (Moder) added a subscriber: Iliya Katueshenock (Moder).Oct 29 2022, 6:46 PM