Page MenuHome
Create Task
Maniphest T89771

Cloth disk cache is not read on library overrides when original linked data is already set to use 'Disk Cache'
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.11

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-09 23:23, hash: rB62d9dabc7db4

Short description of error
Baking cloth with file disk cache used to work. Now it will get ignored on reload

Exact steps for others to reproduce the error
Unpack the following zip

Cloth Library Override.zip186 KBDownload

Open Library Override.blend
Make sure Disk Cache is enabled and Use Library Path is disabled

Click Bake
Save
Reload
The cloth simulation is gone

Here's a video of the problem

Revisions and Commits

rB Blender
rBe00bf04c0f59 Fix T89771: Cloth disk cache is not read on library overrides when original…
rBc9e9a4221545 Fix T89771: Cloth disk cache is not read on library overrides in some cases.

Related Objects

Event Timeline

Daniel Salazar (zanqdo) created this task.Jul 10 2021, 8:20 AM
Daniel Salazar (zanqdo) renamed this task from Cloth disk cache is not read on library overrides to Cloth disk cache is not read on library overrides (regression).Jul 10 2021, 8:39 AM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Jul 10 2021, 2:13 PM

The cloth simulation is gone

Can not reproduce with provided steps on 3.0.0 (rB62d9dabc7db4).

System Information

Operating system : Windows-10-10.0.18362-SP0 64 Bits
Graphics card : AMD Radeon(TM) 535 ATI Technologies .

@Daniel Salazar (zanqdo) , can you please mention the working version also?

Daniel Salazar (zanqdo) added a comment.Jul 10 2021, 9:34 PM
In T89771#1189567, @Pratik Borhade (PratikPB2123) wrote:

The cloth simulation is gone

Can not reproduce with provided steps on 3.0.0 (rB62d9dabc7db4).

System Information

Operating system : Windows-10-10.0.18362-SP0 64 Bits
Graphics card : AMD Radeon(TM) 535 ATI Technologies .

@Daniel Salazar (zanqdo) , can you please mention the working version also?

Hey man, do you mean it works for you? This is related to the Milestone 1 of this project

We made sure the basics for disk cache worked back in 2.92. I'm trying to find out what happened.

Daniel Salazar (zanqdo) assigned this task to Bastien Montagne (mont29).Jul 10 2021, 9:36 PM
Daniel Salazar (zanqdo) added a parent task: T82503: Add Support of PointCaches to Library Overrides.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Jul 10 2021, 10:13 PM
Pratik Borhade (PratikPB2123) added a comment.Jul 11 2021, 5:36 AM

do you mean it works for you?

@Daniel Salazar (zanqdo) , unsure what behavior is expected but seems same output for version 2.92 and above. (sorry for polluting the task)

At least I can say the animation is not lost after reloading the scene.

Daniel Salazar (zanqdo) updated the task description. (Show Details)Jul 12 2021, 10:23 PM
Daniel Salazar (zanqdo) added a comment.Jul 12 2021, 10:25 PM

I'm not sure what's going on on your side but I've added a video to the report

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Jul 13 2021, 11:35 AM
Philipp Oeser (lichtwerk) added a project: Pipeline, Assets & I/O.

I can confirm.

From a first quick look it also seems like the override setting on Disk Cache and Use Library Patch is not consistent?
If I enable Disk Cache and disable Use Library Patch, then save the file and revert/reopen, the setting is back to the original (this should not be the case, right?)

Bastien Montagne (mont29) edited projects, added Core; removed Pipeline, Assets & I/O.Jul 13 2021, 11:55 AM
Bastien Montagne (mont29) moved this task from Backlog to Bugs on the Core board.
Bastien Montagne (mont29) removed a parent task: T82503: Add Support of PointCaches to Library Overrides.Jul 13 2021, 12:23 PM

Please do not add bug as children of TODO/design tasks...

Bastien Montagne (mont29) added a comment.Jul 14 2021, 12:31 PM

This not a regression actually, that specific scenario never worked.

Issue with this case is that disk cache is already enabled in lib data (unlike what would happen by default). So there is nothing to override, and therefore no override rule is created for this setting.

But...... ClothModifier copy code just create a new empty PointCache, which by default has this setting disabled. Since there is no override rule, it remains like that in the override.

Fix incoming (note that issue could be present in other point cache usecases, but am tired of this code, it's is horribly badly handled, in a completely inconsistent way all over the codebase... It's just old system that needs complete redesign. so doing bare minimal changes needed to get this working for now).

Bastien Montagne (mont29) renamed this task from Cloth disk cache is not read on library overrides (regression) to Cloth disk cache is not read on library overrides.Jul 14 2021, 12:31 PM
Bastien Montagne (mont29) renamed this task from Cloth disk cache is not read on library overrides to Cloth disk cache is not read on library overrides when original linked data is already set to use 'Disk Cache'.
Bastien Montagne (mont29) closed this task as Resolved by committing rBc9e9a4221545: Fix T89771: Cloth disk cache is not read on library overrides in some cases..Jul 14 2021, 2:48 PM
Bastien Montagne (mont29) added a commit: rBc9e9a4221545: Fix T89771: Cloth disk cache is not read on library overrides in some cases..
Daniel Salazar (zanqdo) added a comment.Jul 15 2021, 5:57 AM

Hey man I'm sorry but there's no way I can make this thing work :( rB4be166b6b582

Daniel Salazar (zanqdo) reopened this task as Confirmed.Jul 15 2021, 5:58 AM
Bastien Montagne (mont29) closed this task as Resolved by committing rBe00bf04c0f59: Fix T89771: Cloth disk cache is not read on library overrides when original….Oct 20 2021, 5:24 PM
Bastien Montagne (mont29) added a commit: rBe00bf04c0f59: Fix T89771: Cloth disk cache is not read on library overrides when original….