Page MenuHome
Create Task
Maniphest T90412

VSE: Inconsistency in Mask strip color
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 462.59

Blender Version
Broken: version: 2.93.0, branch: master, commit date: 2021-06-02 11:21, hash: rB84da05a8b806

Short description of error
In this patch D6883 the default color of mask strips wasn't aligned to the value of mask strip in the light theme. This means that the documentation referencing the strips colors will be wrong when using the light theme.

The default color of the mask strip is grey. This is problematic since all strips are designed to have non-grey colors, since the greys are reserved the UI and sequencer background.

The light theme in D6883:

The default in D6883:

Abandoned attempt to fix this: D11953

Revisions and Commits

rB Blender
rB61bffa565ec2 Fix T90412: Inconsistency in mask strip color

Related Objects

Event Timeline

Peter Fog (tintwotin) created this task.Aug 3 2021, 4:30 PM
Peter Fog (tintwotin) added projects: Video Sequencer, VFX & Video.
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Needs Information from Developers.Aug 3 2021, 5:26 PM
Philipp Oeser (lichtwerk) added a project: User Interface.
Philipp Oeser (lichtwerk) added subscribers: Richard Antalik (ISS), Philipp Oeser (lichtwerk).

If I read the intentions of D6883 right, then this was indeed a mistake in the original patch.
Not sure why you abandoned D11953 (since only the versioning was missing?).

@Richard Antalik (ISS): will let you decide (but looks like this is going against the original intends...)

Peter Fog (tintwotin) added a comment.Aug 3 2021, 5:49 PM

@Philipp Oeser (lichtwerk) Imo, there was uncertainty concerning the solution I proposed. I do not want to waste time on having patches open due to indecisive processing. So the difference, for me, is that the solution of a patch I submitted is my problem, whereas the solution of a bug report is not my problem.

Richard Antalik (ISS) changed the task status from Needs Information from Developers to Confirmed.Aug 3 2021, 8:55 PM
Richard Antalik (ISS) changed the subtype of this task from "Report" to "Bug".

Yes this indeed looks like a mistake, I missed the point that in light theme this color is already different.

Peter Fog (tintwotin) closed this task as Archived.Oct 26 2021, 8:51 AM

As I do not have anymore time or motivation for a continued investment in the Blender project, I'm giving up on this report for now.

Philipp Oeser (lichtwerk) reopened this task as Confirmed.Oct 26 2021, 9:16 AM

Sorry to hear (thx again reporting). In my opinion we should not sweep this under the carpet (esp. since this already been confirmed), there is still a chance to get this fixed in the future and others might be affected by this issue as well.
Feel free to unsubscribe though.

Peter Fog (tintwotin) removed a subscriber: Peter Fog (tintwotin).Oct 26 2021, 11:25 AM
Richard Antalik (ISS) moved this task from Backlog to 3.0 bugs on the Video Sequencer board.Nov 3 2021, 5:05 AM
Richard Antalik (ISS) closed this task as Resolved by committing rB61bffa565ec2: Fix T90412: Inconsistency in mask strip color.Nov 17 2021, 3:30 AM
Richard Antalik (ISS) claimed this task.
Richard Antalik (ISS) added a commit: rB61bffa565ec2: Fix T90412: Inconsistency in mask strip color.