Page MenuHome

VSE Transform Tools: Drag options in the sidebar are not working
Closed, ArchivedPublic

Description

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 462.59

Blender Version
Broken: version: 3.0.0 Alpha, branch: master (modified), commit date: 2021-09-22 05:59, hash: rB3fa64263927f

Short description of error
None of these options are having any effect as compared to ex. the 3d view where the expected behaviour can be tried out:

Steps to Reproduce 1

  • File -> New -> Video Editing
  • Add image or image sequence
  • Select Move tool
  • Choose Active Tool as a drag option from sidebar
  • Drag in an empty area
  • In the 3d view the active tool Move kicks in and moved the object.
  • In the Sequencer Preview the strip gets deselected, and it isn't moving.

Expected behaviour: That the preview tool works in consistency with the similar tool in the 3d view.

Steps to Reproduce 2

  • File -> New -> Video Editing
  • Add image or image sequence
  • Select Move tool
  • Choose select box as a drag option from sidebar
  • Select images from Preview tab
  • From sidebar, change the select box mode to subtract or extend.

Expected behaviour: That the preview tool works in consistency with the similar tool in the 3d view.

Steps to Reproduce X
Please do a proper test of the additional options are working in consistency with the 3d view.

The problem for all of the mis behaviours is that it might just do ordinary select in those cases.

https://developer.blender.org/D12105#326398

Event Timeline

Hi @Peter Fog (tintwotin) , thanks for the report. Did you try this case on fresh builds?: https://builder.blender.org/download/daily

I'm not able to reproduce this on current master: rBbc65c7d0e579c19169baf8be609afa066712c2cc

(Will look for the commit which fixes this)

Pratik Borhade (PratikPB2123) closed this task as Resolved.EditedSep 24 2021, 9:32 AM

Campbell Barton has already committed the fix: rBc75e6bcea27d: Keymap: add fallback keymap for sequencer tools

Closing the report for now but feel free to comment if you are still able to reproduce this on current master. Thanks again for the report :)

@Pratik Borhade (PratikPB2123)

In a build of the latest master ex. dragging while in "active tool" is deselecting, whereas it should move, and subtract from selection, deselects all and select just with in the box:

Campbell Barton has already committed the fix: rBc75e6bcea27d: Keymap: add fallback keymap for sequencer tools

Closing the report for now but feel free to comment if you are still able to reproduce this on current master. Thanks again for the report :)

The gif was made with a fresh build of the latest master two days after that commit, so the incomplete implementation/bug still persists.

@Pratik Borhade (PratikPB2123) Can you reopen this report, or should I spend additional time on making a new one?

Pratik Borhade (PratikPB2123) reopened this task as Needs Triage.Sep 24 2021, 10:42 AM
Pratik Borhade (PratikPB2123) changed the task status from Needs Triage to Confirmed.EditedSep 24 2021, 11:19 AM

Hi, updated the report. Thanks for the gif.

In a build of the latest master ex. dragging while in "active tool" is deselecting

Can you please create a separate report for it? Not sure if it is a good idea to keep it in the same report.

Also removing Campbell as a assignee because the task is open again :)

Campbell Barton has already committed the fix rBc75e6bcea27d: Keymap: add fallback keymap for sequencer tools

Every drag option had the same behavior a few days before. Above commit has actually resolved that issue. Assuming the reported problem is about this, I had closed the ticket.

Peter Fog (tintwotin) changed the task status from Confirmed to Needs Triage.Sep 24 2021, 11:22 AM
Peter Fog (tintwotin) changed the task status from Needs Triage to Confirmed.
Peter Fog (tintwotin) removed Campbell Barton (campbellbarton) as the assignee of this task.
Peter Fog (tintwotin) updated the task description. (Show Details)

Described issues are partially fixed with the commit rBba95cf6234af: Keymap: remove selection from the common sequencer map

Also @Peter Fog (tintwotin) has created a separate report for the pending problem: T91978: VSE Preview Transform: Subtract selection doesn't work

This can be closed I think.

(Will have to double check if the obtained commit after bisecting is correct or not)

The remaining issues are described in T91978, so closing this one.