Page MenuHome
Create Task
Maniphest T95981

Setting Masking->Stencil Mask->Stencil Image crashes Blender. Includes fix
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Linux-5.4.0-100-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: NVIDIA GeForce GTX 750 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.103.01

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-02-23 01:31, hash: rBc6df7266c718
Worked: 3.0.1 (Think the issue started sometime in the 3.1.0 Alpha cycle)

Caused by rB9d3f35a0bf1b: Revert "Revert "GPUShaderCreateInfo for interface abstraction"" look at that :)

Short description of error
Setting Stencil Mask->Stencil Image either by creating a new image or selecting an existing image will immediate crash Blender.
Bug affects both linux and windows and is 100% reproducible on my system.

Exact steps for others to reproduce the error

mask_tool_crash_02.blend779 KBDownload

  1. Load the attached .blend file (Optional:switch to the mask tool)
  1. In the 3D view, scroll the tool tab down to Masking->Stencil Mask->Stencil Image
  1. Click the 'New' button then click 'Ok' to accept the defaults
  1. crash straight to the desktop

I've also attached the error message that you'll receive after the crash if you start blender via a terminal or cmd prompt.

stencil_masking_error_01.txt503 BDownload

It explains the problem: the smoothstep function is now interpreting "0" as an integer, rather than assuming it's a float.

The Fix

Edit: blender-git/blender/source/blender/draw/engines/overlay/shaders/paint_texture_frag.glsl

simply change line 18 from:
float mask_step = smoothstep(0, 3.0, mask.r + mask.g + mask.b);
to:
float mask_step = smoothstep(0.0, 3.0, mask.r + mask.g + mask.b);

I've tested this by locally compiling a version of Blender with this change and it creates a binary that works as expected and does not crash when setting the stencil mask.

Revisions and Commits

rB Blender
rB2a644deaa7b2 Fix T95981: Remove implicit conversion in texture paint shader.

Related Objects

Event Timeline

Jeff Dierstein (elkmug) created this task.Feb 23 2022, 6:44 AM
Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Feb 23 2022, 7:14 AM
Pratik Borhade (PratikPB2123) added a comment.Feb 23 2022, 8:15 AM

Doesn't crash on latest master 165b030b19718694eaf33d6602034ed88fdd31a1
Perhaps crash is specific for NVIDIA GPU?

System Information
Operating system : Windows-10-10.0.18362-SP0 64 Bits
Graphics card : AMD Radeon(TM) 535 ATI Technologies .
Graphics card: Intel(R) UHD Graphics 620 Intel 4.5.0 - Build 26.20.100.7323
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Feb 23 2022, 8:32 AM
Philipp Oeser (lichtwerk) triaged this task as High priority.
Philipp Oeser (lichtwerk) added projects: Sculpt, Paint & Texture, EEVEE & Viewport.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Can confirm. Will check.

Omar Emara (OmarSquircleArt) added a subscriber: Omar Emara (OmarSquircleArt).Feb 23 2022, 8:35 AM

Even if the implicit conversion is guaranteed by the specification, this seems like an easy fix.
@Jeff Dierstein (elkmug) If you are interested in submitting your fix as patch, check https://wiki.blender.org/wiki/Process/Contributing_Code.

Philipp Oeser (lichtwerk) added a subscriber: Jeroen Bakker (jbakker).Feb 23 2022, 8:58 AM

Caused by rB9d3f35a0bf1b: Revert "Revert "GPUShaderCreateInfo for interface abstraction"" look at that :)

CC @Jeroen Bakker (jbakker)

Philipp Oeser (lichtwerk) updated the task description. (Show Details)Feb 23 2022, 8:59 AM
Thomas Dinges (dingto) edited projects, added BF Blender (3.1); removed BF Blender.Feb 24 2022, 3:17 PM
Jeroen Bakker (jbakker) claimed this task.Feb 28 2022, 8:20 AM
Jeroen Bakker (jbakker) added a comment.EditedFeb 28 2022, 8:39 AM

Not able to reproduce, but it is known that some drivers don't handle implicit conversions that well. Will apply the fix. Thanks!
Interesting that this was already there for 2 years...

Jeroen Bakker (jbakker) closed this task as Resolved by committing rB2a644deaa7b2: Fix T95981: Remove implicit conversion in texture paint shader..Feb 28 2022, 9:06 AM
Jeroen Bakker (jbakker) added a commit: rB2a644deaa7b2: Fix T95981: Remove implicit conversion in texture paint shader..